diff mbox series

[v2,3/3] ARM: dts: add ehci uhci enable in evb dts

Message ID 20201009024937.11246-4-ryan_chen@aspeedtech.com (mailing list archive)
State New, archived
Headers show
Series Enable USB host for AST2600 | expand

Commit Message

Ryan Chen Oct. 9, 2020, 2:49 a.m. UTC
Add EHCI UHCI enable build in aspeed-ast2600-evb.dts

Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
---
 arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Sergey Shtylyov Oct. 9, 2020, 8:22 a.m. UTC | #1
HEllo!

On 09.10.2020 5:49, Ryan Chen wrote:

> Add EHCI UHCI enable build in aspeed-ast2600-evb.dts

    Enable ECHI/UHCI for the  Aspeed AST2600 EVB, perhaps?

> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
[...]

MBR, Sergei
Ryan Chen Oct. 12, 2020, 12:43 a.m. UTC | #2
Hello Segei,

> -----Original Message-----
> From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> Sent: Friday, October 9, 2020 4:23 PM
> To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley <joel@jms.id.au>;
> Andrew Jeffery <andrew@aj.id.au>; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan Stern
> <stern@rowland.harvard.edu>
> Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
> 
> HEllo!
> 
> On 09.10.2020 5:49, Ryan Chen wrote:
> 
> > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
> 
>     Enable ECHI/UHCI for the  Aspeed AST2600 EVB, perhaps?
> 

Yes, it is enable for AST2600 EVB. 

> > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> [...]
> 
> MBR, Sergei
Andrew Jeffery Oct. 21, 2020, 11:44 p.m. UTC | #3
Hi Ryan,

On Mon, 12 Oct 2020, at 11:13, Ryan Chen wrote:
> Hello Segei,
> 
> > -----Original Message-----
> > From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> > Sent: Friday, October 9, 2020 4:23 PM
> > To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley <joel@jms.id.au>;
> > Andrew Jeffery <andrew@aj.id.au>; linux-arm-kernel@lists.infradead.org;
> > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> > linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan Stern
> > <stern@rowland.harvard.edu>
> > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
> > 
> > HEllo!
> > 
> > On 09.10.2020 5:49, Ryan Chen wrote:
> > 
> > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
> > 
> >     Enable ECHI/UHCI for the  Aspeed AST2600 EVB, perhaps?
> > 
> 
> Yes, it is enable for AST2600 EVB. 

I think Sergei was suggesting you change the wording of the commit message.

Andrew
Ryan Chen Oct. 22, 2020, 7:21 a.m. UTC | #4
> -----Original Message-----
> From: Andrew Jeffery <andrew@aj.id.au>
> Sent: Thursday, October 22, 2020 7:45 AM
> To: Ryan Chen <ryan_chen@aspeedtech.com>; Sergei Shtylyov
> <sergei.shtylyov@gmail.com>; Joel Stanley <joel@jms.id.au>;
> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; BMC-SW
> <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu>
> Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
> 
> Hi Ryan,
> 
> On Mon, 12 Oct 2020, at 11:13, Ryan Chen wrote:
> > Hello Segei,
> >
> > > -----Original Message-----
> > > From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> > > Sent: Friday, October 9, 2020 4:23 PM
> > > To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley
> > > <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>;
> > > linux-arm-kernel@lists.infradead.org;
> > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> > > linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan
> > > Stern <stern@rowland.harvard.edu>
> > > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb
> > > dts
> > >
> > > HEllo!
> > >
> > > On 09.10.2020 5:49, Ryan Chen wrote:
> > >
> > > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
> > >
> > >     Enable ECHI/UHCI for the  Aspeed AST2600 EVB, perhaps?
> > >
> >
> > Yes, it is enable for AST2600 EVB.
> 
> I think Sergei was suggesting you change the wording of the commit message.
> 
Thanks, will resend the patch with modification.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
index 89be13197780..2772796e215e 100644
--- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
+++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
@@ -237,3 +237,11 @@ 
 &fsim0 {
 	status = "okay";
 };
+
+&ehci1 {
+	status = "okay";
+};
+
+&uhci {
+	status = "okay";
+};