diff mbox series

[v2] usb: serial: iuu_phoenix remove unneeded break

Message ID 20201026191450.1429945-1-trix@redhat.com (mailing list archive)
State Accepted
Commit d1849b9ff9f442b3720e07b2d6f6c5cf1b97b1a3
Headers show
Series [v2] usb: serial: iuu_phoenix remove unneeded break | expand

Commit Message

Tom Rix Oct. 26, 2020, 7:14 p.m. UTC 
From: Tom Rix <trix@redhat.com>

A break is not needed if it is preceded by a return.

Signed-off-by: Tom Rix <trix@redhat.com>
---
v2: split from original larger patch
---
 drivers/usb/serial/iuu_phoenix.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Johan Hovold Oct. 27, 2020, 8:38 a.m. UTC | #1 
On Mon, Oct 26, 2020 at 12:14:50PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> A break is not needed if it is preceded by a return.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> v2: split from original larger patch

Applied, thanks.

Johan
diff mbox series

Patch

diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index b4ba79123d9d..f1201d4de297 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -850,7 +850,6 @@  static int iuu_uart_baud(struct usb_serial_port *port, u32 baud_base,
 	default:
 		kfree(dataout);
 		return IUU_INVALID_PARAMETER;
-		break;
 	}
 
 	switch (parity & 0xF0) {
@@ -864,7 +863,6 @@  static int iuu_uart_baud(struct usb_serial_port *port, u32 baud_base,
 	default:
 		kfree(dataout);
 		return IUU_INVALID_PARAMETER;
-		break;
 	}
 
 	status = bulk_immediate(port, dataout, DataCount);