| Message ID | 20201110003716.5164-3-utkarsh.h.patel@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Thunderbolt3/USB4 cable rounded and active cable plug link training support | expand |
On Mon, Nov 09, 2020 at 04:37:10PM -0800, Utkarsh Patel wrote: > Thunderbolt rounded/non-rounded cable support is two bits value. Correcting > it as per the Thunderbolt 3 cable discover mode VDO changes done in the > Thunderbolt 3 alternate mode header. > > Fixes: 5b30bd35aab4 ("platform/chrome: cros_ec_typec: Add TBT compat support") Again the fix tag? > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> > --- > drivers/platform/chrome/cros_ec_typec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index 31be31161350..8111ed1fc574 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -438,8 +438,7 @@ static int cros_typec_enable_tbt(struct cros_typec_data *typec, > if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_LINK_UNIDIR) > data.cable_mode |= TBT_CABLE_LINK_TRAINING; > > - if (pd_ctrl->cable_gen) > - data.cable_mode |= TBT_CABLE_ROUNDED; > + data.cable_mode |= TBT_SET_CABLE_ROUNDED(pd_ctrl->cable_gen); > > /* Enter Mode VDO */ > data.enter_vdo = TBT_SET_CABLE_SPEED(pd_ctrl->cable_speed); > -- > 2.17.1 thanks,
Hi Heikki, > -----Original Message----- > From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Sent: Tuesday, November 10, 2020 4:19 AM > To: Patel, Utkarsh H <utkarsh.h.patel@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; > pmalani@chromium.org; enric.balletbo@collabora.com; Mani, Rajmohan > <rajmohan.mani@intel.com>; Shaikh, Azhar <azhar.shaikh@intel.com> > Subject: Re: [PATCH 2/8] platform/chrome: cros_ec_typec: Correct the > Thunderbolt rounded/non-rounded cable support > > On Mon, Nov 09, 2020 at 04:37:10PM -0800, Utkarsh Patel wrote: > > Thunderbolt rounded/non-rounded cable support is two bits value. > > Correcting it as per the Thunderbolt 3 cable discover mode VDO changes > > done in the Thunderbolt 3 alternate mode header. > > > > Fixes: 5b30bd35aab4 ("platform/chrome: cros_ec_typec: Add TBT compat > > support") > > Again the fix tag? Ack. I will remove the fix tag in v2. > > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> > > --- > > drivers/platform/chrome/cros_ec_typec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/platform/chrome/cros_ec_typec.c > > b/drivers/platform/chrome/cros_ec_typec.c > > index 31be31161350..8111ed1fc574 100644 > > --- a/drivers/platform/chrome/cros_ec_typec.c > > +++ b/drivers/platform/chrome/cros_ec_typec.c > > @@ -438,8 +438,7 @@ static int cros_typec_enable_tbt(struct > cros_typec_data *typec, > > if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_LINK_UNIDIR) > > data.cable_mode |= TBT_CABLE_LINK_TRAINING; > > > > - if (pd_ctrl->cable_gen) > > - data.cable_mode |= TBT_CABLE_ROUNDED; > > + data.cable_mode |= TBT_SET_CABLE_ROUNDED(pd_ctrl->cable_gen); > > > > /* Enter Mode VDO */ > > data.enter_vdo = TBT_SET_CABLE_SPEED(pd_ctrl->cable_speed); > > -- > > 2.17.1 > > thanks, > > -- > Heikki Sincerely, Utkarsh Patel.
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 31be31161350..8111ed1fc574 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -438,8 +438,7 @@ static int cros_typec_enable_tbt(struct cros_typec_data *typec, if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_LINK_UNIDIR) data.cable_mode |= TBT_CABLE_LINK_TRAINING; - if (pd_ctrl->cable_gen) - data.cable_mode |= TBT_CABLE_ROUNDED; + data.cable_mode |= TBT_SET_CABLE_ROUNDED(pd_ctrl->cable_gen); /* Enter Mode VDO */ data.enter_vdo = TBT_SET_CABLE_SPEED(pd_ctrl->cable_speed);
Thunderbolt rounded/non-rounded cable support is two bits value. Correcting it as per the Thunderbolt 3 cable discover mode VDO changes done in the Thunderbolt 3 alternate mode header. Fixes: 5b30bd35aab4 ("platform/chrome: cros_ec_typec: Add TBT compat support") Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> --- drivers/platform/chrome/cros_ec_typec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)