| Message ID | 20201110003716.5164-5-utkarsh.h.patel@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Thunderbolt3/USB4 cable rounded and active cable plug link training support | expand |
On Mon, Nov 09, 2020 at 04:37:12PM -0800, Utkarsh Patel wrote: > Two bits support for the Thunderbolt rounded/non-rounded cable has been > added to the header file. > Hence, removing unused TBT_CABLE_ROUNDED definition from the header file. > > Fixes: ca469c292edc ("usb: typec: Add definitions for Thunderbolt 3 Alternate Mode") And again? > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> > --- > include/linux/usb/typec_tbt.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/usb/typec_tbt.h b/include/linux/usb/typec_tbt.h > index aad648d14bb3..63dd44b72e0c 100644 > --- a/include/linux/usb/typec_tbt.h > +++ b/include/linux/usb/typec_tbt.h > @@ -39,7 +39,6 @@ struct typec_thunderbolt_data { > #define TBT_CABLE_USB3_GEN1 1 > #define TBT_CABLE_USB3_PASSIVE 2 > #define TBT_CABLE_10_AND_20GBPS 3 > -#define TBT_CABLE_ROUNDED BIT(19) > #define TBT_CABLE_ROUNDED_SUPPORT(_vdo_) \ > (((_vdo_) & GENMASK(20, 19)) >> 19) > #define TBT_GEN3_NON_ROUNDED 0 thanks,
Hi Heikki, > -----Original Message----- > From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Sent: Tuesday, November 10, 2020 4:20 AM > To: Patel, Utkarsh H <utkarsh.h.patel@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; > pmalani@chromium.org; enric.balletbo@collabora.com; Mani, Rajmohan > <rajmohan.mani@intel.com>; Shaikh, Azhar <azhar.shaikh@intel.com> > Subject: Re: [PATCH 4/8] usb: typec: Remove one bit support for the > Thunderbolt rounded/non-rounded cable > > On Mon, Nov 09, 2020 at 04:37:12PM -0800, Utkarsh Patel wrote: > > Two bits support for the Thunderbolt rounded/non-rounded cable has > > been added to the header file. > > Hence, removing unused TBT_CABLE_ROUNDED definition from the header > file. > > > > Fixes: ca469c292edc ("usb: typec: Add definitions for Thunderbolt 3 > > Alternate Mode") > > And again? Ack. I will remove the fix tag in v2. > > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> > > --- > > include/linux/usb/typec_tbt.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/linux/usb/typec_tbt.h > > b/include/linux/usb/typec_tbt.h index aad648d14bb3..63dd44b72e0c > > 100644 > > --- a/include/linux/usb/typec_tbt.h > > +++ b/include/linux/usb/typec_tbt.h > > @@ -39,7 +39,6 @@ struct typec_thunderbolt_data { > > #define TBT_CABLE_USB3_GEN1 1 > > #define TBT_CABLE_USB3_PASSIVE 2 > > #define TBT_CABLE_10_AND_20GBPS 3 > > -#define TBT_CABLE_ROUNDED BIT(19) > > #define TBT_CABLE_ROUNDED_SUPPORT(_vdo_) \ > > (((_vdo_) & GENMASK(20, 19)) >> 19) > > #define TBT_GEN3_NON_ROUNDED 0 > > thanks, > > -- > Heikki Sincerely, Utkarsh Patel.
diff --git a/include/linux/usb/typec_tbt.h b/include/linux/usb/typec_tbt.h index aad648d14bb3..63dd44b72e0c 100644 --- a/include/linux/usb/typec_tbt.h +++ b/include/linux/usb/typec_tbt.h @@ -39,7 +39,6 @@ struct typec_thunderbolt_data { #define TBT_CABLE_USB3_GEN1 1 #define TBT_CABLE_USB3_PASSIVE 2 #define TBT_CABLE_10_AND_20GBPS 3 -#define TBT_CABLE_ROUNDED BIT(19) #define TBT_CABLE_ROUNDED_SUPPORT(_vdo_) \ (((_vdo_) & GENMASK(20, 19)) >> 19) #define TBT_GEN3_NON_ROUNDED 0
Two bits support for the Thunderbolt rounded/non-rounded cable has been added to the header file. Hence, removing unused TBT_CABLE_ROUNDED definition from the header file. Fixes: ca469c292edc ("usb: typec: Add definitions for Thunderbolt 3 Alternate Mode") Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> --- include/linux/usb/typec_tbt.h | 1 - 1 file changed, 1 deletion(-)