| Message ID | 20201116040653.7943-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 24880a87042b3032a6ac04d79cb51892c5a7901d |
| Headers | show |
| Series | usb: typec: qcom-pmic-typec: fix builtin build errors | expand |
On Sun, Nov 15, 2020 at 08:06:53PM -0800, Randy Dunlap wrote: > Fix build errors when CONFIG_TYPEC_QCOM_PMIC=y and > CONFIG_USB_ROLE_SWITCH=m by limiting the former to =m when > USB_ROLE_SWITCH also =m. > > powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_remove': > qcom-pmic-typec.c:(.text+0x28): undefined reference to `.usb_role_switch_set_role' > powerpc64-linux-ld: qcom-pmic-typec.c:(.text+0x64): undefined reference to `.usb_role_switch_put' > powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_check_connection': > qcom-pmic-typec.c:(.text+0x120): undefined reference to `.usb_role_switch_set_role' > powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_probe': > qcom-pmic-typec.c:(.text+0x360): undefined reference to `.fwnode_usb_role_switch_get' > powerpc64-linux-ld: qcom-pmic-typec.c:(.text+0x4e4): undefined reference to `.usb_role_switch_put' > > Fixes: 6c8cf3695176 ("usb: typec: Add QCOM PMIC typec detection driver") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: linux-usb@vger.kernel.org > Cc: Wesley Cheng <wcheng@codeaurora.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20201113.orig/drivers/usb/typec/Kconfig > +++ linux-next-20201113/drivers/usb/typec/Kconfig > @@ -88,6 +88,7 @@ config TYPEC_STUSB160X > config TYPEC_QCOM_PMIC > tristate "Qualcomm PMIC USB Type-C driver" > depends on ARCH_QCOM || COMPILE_TEST > + depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > help > Driver for supporting role switch over the Qualcomm PMIC. This will > handle the USB Type-C role and orientation detection reported by the
--- linux-next-20201113.orig/drivers/usb/typec/Kconfig +++ linux-next-20201113/drivers/usb/typec/Kconfig @@ -88,6 +88,7 @@ config TYPEC_STUSB160X config TYPEC_QCOM_PMIC tristate "Qualcomm PMIC USB Type-C driver" depends on ARCH_QCOM || COMPILE_TEST + depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH help Driver for supporting role switch over the Qualcomm PMIC. This will handle the USB Type-C role and orientation detection reported by the
Fix build errors when CONFIG_TYPEC_QCOM_PMIC=y and CONFIG_USB_ROLE_SWITCH=m by limiting the former to =m when USB_ROLE_SWITCH also =m. powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_remove': qcom-pmic-typec.c:(.text+0x28): undefined reference to `.usb_role_switch_set_role' powerpc64-linux-ld: qcom-pmic-typec.c:(.text+0x64): undefined reference to `.usb_role_switch_put' powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_check_connection': qcom-pmic-typec.c:(.text+0x120): undefined reference to `.usb_role_switch_set_role' powerpc64-linux-ld: drivers/usb/typec/qcom-pmic-typec.o: in function `.qcom_pmic_typec_probe': qcom-pmic-typec.c:(.text+0x360): undefined reference to `.fwnode_usb_role_switch_get' powerpc64-linux-ld: qcom-pmic-typec.c:(.text+0x4e4): undefined reference to `.usb_role_switch_put' Fixes: 6c8cf3695176 ("usb: typec: Add QCOM PMIC typec detection driver") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> Cc: linux-usb@vger.kernel.org Cc: Wesley Cheng <wcheng@codeaurora.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)