| Message ID | 20201208195547.30076-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b13f020d0c9f03d8c6f63f06ac4cfea76a212afb |
| Headers | show |
| Series | [-next] usb: cdns3: fix warning when USB_CDNS_HOST is not set | expand |
> In file included from ../drivers/usb/cdns3/core.c:23:0: > ../drivers/usb/cdns3/host-export.h:27:51: warning: ‘struct usb_hcd’ declared > inside parameter list will not be visible outside of this definition or declaration > static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd) > ^~~~~~~ > Applied both, thanks. Peter > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Peter Chen <peter.chen@nxp.com> > Cc: Pawel Laszczak <pawell@cadence.com> > Cc: Roger Quadros <rogerq@ti.com> > Cc: linux-usb@vger.kernel.org > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/usb/cdns3/host-export.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20201208.orig/drivers/usb/cdns3/host-export.h > +++ linux-next-20201208/drivers/usb/cdns3/host-export.h > @@ -9,10 +9,10 @@ > #ifndef __LINUX_CDNS3_HOST_EXPORT > #define __LINUX_CDNS3_HOST_EXPORT > > -#if IS_ENABLED(CONFIG_USB_CDNS_HOST) > - > struct usb_hcd; > > +#if IS_ENABLED(CONFIG_USB_CDNS_HOST) > + > int cdns_host_init(struct cdns *cdns); > int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd); >
--- linux-next-20201208.orig/drivers/usb/cdns3/host-export.h +++ linux-next-20201208/drivers/usb/cdns3/host-export.h @@ -9,10 +9,10 @@ #ifndef __LINUX_CDNS3_HOST_EXPORT #define __LINUX_CDNS3_HOST_EXPORT -#if IS_ENABLED(CONFIG_USB_CDNS_HOST) - struct usb_hcd; +#if IS_ENABLED(CONFIG_USB_CDNS_HOST) + int cdns_host_init(struct cdns *cdns); int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
Fix a build warning when USB_CDNS_HOST is not enabled: In file included from ../drivers/usb/cdns3/core.c:23:0: ../drivers/usb/cdns3/host-export.h:27:51: warning: ‘struct usb_hcd’ declared inside parameter list will not be visible outside of this definition or declaration static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd) ^~~~~~~ Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Peter Chen <peter.chen@nxp.com> Cc: Pawel Laszczak <pawell@cadence.com> Cc: Roger Quadros <rogerq@ti.com> Cc: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/usb/cdns3/host-export.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)