[v4,02/10] arm64: dts: amlogic: meson-g12: Set FL-adj property value

Commit Message

Serge Semin Dec. 10, 2020, 9:17 a.m. UTC

In accordance with the DWC USB3 bindings the property is supposed to have
uint32 type. It's erroneous from the DT schema and driver points of view
to declare it as boolean. As Neil suggested set it to 0x20 so not break
the platform and to make the dtbs checker happy.

Link: https://lore.kernel.org/linux-usb/[e-mail]/
Signed-off-by: Serge Semin <[e-mail]>
Reviewed-by: Martin Blumenstingl <[e-mail]>
Reviewed-by: Neil Armstrong <[e-mail]>
Reviewed-by: Krzysztof Kozlowski <[e-mail]>
---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kevin Hilman Dec. 11, 2020, 7:06 p.m. UTC | #1

Serge Semin <[e-mail]> writes:

> In accordance with the DWC USB3 bindings the property is supposed to have
> uint32 type. It's erroneous from the DT schema and driver points of view
> to declare it as boolean. As Neil suggested set it to 0x20 so not break
> the platform and to make the dtbs checker happy.
>
> Link: https://lore.kernel.org/linux-usb/[e-mail]/
> Signed-off-by: Serge Semin <[e-mail]>
> Reviewed-by: Martin Blumenstingl <[e-mail]>
> Reviewed-by: Neil Armstrong <[e-mail]>
> Reviewed-by: Krzysztof Kozlowski <[e-mail]>

Queuing for fixes after adding:

Fixes: 9baf7d6be730 ("arm64: dts: meson: g12a: Add G12A USB nodes")

Thanks,

Kevin

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index 8514fe6a275a..a6127002573b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -2384,7 +2384,7 @@  dwc3: usb@ff500000 {
 				interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
 				dr_mode = "host";
 				snps,dis_u2_susphy_quirk;
-				snps,quirk-frame-length-adjustment;
+				snps,quirk-frame-length-adjustment = <0x20>;
 				snps,parkmode-disable-ss-quirk;
 			};
 		};