| Message ID | 20210110083707.GA11888@himera.home (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4] ehci: fix EHCI host controller initialization sequence | expand |
On Sun, Jan 10, 2021 at 11:37:07AM +0300, Eugene Korenevsky wrote: > According to EHCI spec, EHCI HC clears USBSTS.HCHalted whenever > USBCMD.RS=1. > > However, it is a good practice to wait some time after setting USBCMD.RS > (approximately 100ms) until USBSTS.HCHalted become zero. > > Without this waiting, VirtualBox's EHCI virtual HC accidentally hangs > (see BugLink). > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=211095 > Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru> > --- > drivers/usb/host/ehci-hcd.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index e358ae17d51e..1926b328b6aa 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -574,6 +574,7 @@ static int ehci_run (struct usb_hcd *hcd) > struct ehci_hcd *ehci = hcd_to_ehci (hcd); > u32 temp; > u32 hcc_params; > + int rc; > > hcd->uses_new_polling = 1; > > @@ -629,9 +630,20 @@ static int ehci_run (struct usb_hcd *hcd) > down_write(&ehci_cf_port_reset_rwsem); > ehci->rh_state = EHCI_RH_RUNNING; > ehci_writel(ehci, FLAG_CF, &ehci->regs->configured_flag); > + > + /* Wait until HC become operational */ > ehci_readl(ehci, &ehci->regs->command); /* unblock posted writes */ > msleep(5); > + rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, 0, 100 * 1000); > + > up_write(&ehci_cf_port_reset_rwsem); > + > + if (rc) { > + ehci_err(ehci, "USB %x.%x, controller refused to start: %d\n", > + ((ehci->sbrn & 0xf0)>>4), (ehci->sbrn & 0x0f), rc); > + return rc; > + } > + > ehci->last_periodic_enable = ktime_get_real(); > > temp = HC_VERSION(ehci, ehci_readl(ehci, &ehci->caps->hc_capbase)); > -- > 2.20.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index e358ae17d51e..1926b328b6aa 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -574,6 +574,7 @@ static int ehci_run (struct usb_hcd *hcd) struct ehci_hcd *ehci = hcd_to_ehci (hcd); u32 temp; u32 hcc_params; + int rc; hcd->uses_new_polling = 1; @@ -629,9 +630,20 @@ static int ehci_run (struct usb_hcd *hcd) down_write(&ehci_cf_port_reset_rwsem); ehci->rh_state = EHCI_RH_RUNNING; ehci_writel(ehci, FLAG_CF, &ehci->regs->configured_flag); + + /* Wait until HC become operational */ ehci_readl(ehci, &ehci->regs->command); /* unblock posted writes */ msleep(5); + rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, 0, 100 * 1000); + up_write(&ehci_cf_port_reset_rwsem); + + if (rc) { + ehci_err(ehci, "USB %x.%x, controller refused to start: %d\n", + ((ehci->sbrn & 0xf0)>>4), (ehci->sbrn & 0x0f), rc); + return rc; + } + ehci->last_periodic_enable = ktime_get_real(); temp = HC_VERSION(ehci, ehci_readl(ehci, &ehci->caps->hc_capbase));
According to EHCI spec, EHCI HC clears USBSTS.HCHalted whenever USBCMD.RS=1. However, it is a good practice to wait some time after setting USBCMD.RS (approximately 100ms) until USBSTS.HCHalted become zero. Without this waiting, VirtualBox's EHCI virtual HC accidentally hangs (see BugLink). BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=211095 Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru> --- drivers/usb/host/ehci-hcd.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)