diff mbox series

[v2,2/6] usb: dwc2: pci: Drop the empty quirk function

Message ID 20210204141711.53775-3-heikki.krogerus@linux.intel.com (mailing list archive)
State Accepted
Commit e81dee5554171adf11a45533ab8631ba060a02b7
Headers show
Series usb: Handle device properties with software node API | expand

Commit Message

Heikki Krogerus Feb. 4, 2021, 2:17 p.m. UTC 
The function dwc2_pci_quirks() does nothing. Removing.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Minas Harutyunyan <hminas@synopsys.com>
---
 drivers/usb/dwc2/pci.c | 18 ------------------
 1 file changed, 18 deletions(-)

Comments

Greg Kroah-Hartman Feb. 4, 2021, 2:40 p.m. UTC | #1 
On Thu, Feb 04, 2021 at 05:17:07PM +0300, Heikki Krogerus wrote:
> The function dwc2_pci_quirks() does nothing. Removing.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Minas Harutyunyan <hminas@synopsys.com>
> ---
>  drivers/usb/dwc2/pci.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
> index 7afc10872f1f0..0000151e3ca96 100644
> --- a/drivers/usb/dwc2/pci.c
> +++ b/drivers/usb/dwc2/pci.c
> @@ -63,20 +63,6 @@ struct dwc2_pci_glue {
>  	struct platform_device *phy;
>  };
>  
> -static int dwc2_pci_quirks(struct pci_dev *pdev, struct platform_device *dwc2)
> -{
> -	if (pdev->vendor == PCI_VENDOR_ID_SYNOPSYS &&
> -	    pdev->device == PCI_PRODUCT_ID_HAPS_HSOTG) {
> -		struct property_entry properties[] = {
> -			{ },
> -		};
> -
> -		return platform_device_add_properties(dwc2, properties);
> -	}
> -
> -	return 0;
> -}
> -
>  /**
>   * dwc2_pci_probe() - Provides the cleanup entry points for the DWC_otg PCI
>   * driver
> @@ -143,10 +129,6 @@ static int dwc2_pci_probe(struct pci_dev *pci,
>  
>  	dwc2->dev.parent = dev;
>  
> -	ret = dwc2_pci_quirks(pci, dwc2);
> -	if (ret)
> -		goto err;
> -
>  	glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
>  	if (!glue) {
>  		ret = -ENOMEM;

This is crazy.  I'll go apply this right now :)

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
index 7afc10872f1f0..0000151e3ca96 100644
--- a/drivers/usb/dwc2/pci.c
+++ b/drivers/usb/dwc2/pci.c
@@ -63,20 +63,6 @@  struct dwc2_pci_glue {
 	struct platform_device *phy;
 };
 
-static int dwc2_pci_quirks(struct pci_dev *pdev, struct platform_device *dwc2)
-{
-	if (pdev->vendor == PCI_VENDOR_ID_SYNOPSYS &&
-	    pdev->device == PCI_PRODUCT_ID_HAPS_HSOTG) {
-		struct property_entry properties[] = {
-			{ },
-		};
-
-		return platform_device_add_properties(dwc2, properties);
-	}
-
-	return 0;
-}
-
 /**
  * dwc2_pci_probe() - Provides the cleanup entry points for the DWC_otg PCI
  * driver
@@ -143,10 +129,6 @@  static int dwc2_pci_probe(struct pci_dev *pci,
 
 	dwc2->dev.parent = dev;
 
-	ret = dwc2_pci_quirks(pci, dwc2);
-	if (ret)
-		goto err;
-
 	glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
 	if (!glue) {
 		ret = -ENOMEM;