| Message ID | 20210208114538.134766-1-taehyun.cho@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: dwc3: make USB_DWC3_EXYNOS independent | expand |
On Mon, Feb 08, 2021 at 08:45:38PM +0900, taehyun cho wrote: > 'ARCH_EXYNOS' is no more used. I do not understand this sentance. I see it used in many places in the kernel tree still, is it being removed? And if so, as of what commit is this true? > 'USB_DWC3_EXYNOS' is glue layer > which can be used with Synopsys DWC3 controller on Exynos SoCs. > 'USB_DWC3_EXYNOS' can be used from Exynos5 to Exynos9. This is fine, but the help text doesn't show this, why not put that information there? > > Signed-off-by: taehyun cho <taehyun.cho@samsung.com> > --- > drivers/usb/dwc3/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 2133acf8ee69..dc2f92ac8ef6 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -67,10 +67,10 @@ config USB_DWC3_OMAP > > config USB_DWC3_EXYNOS > tristate "Samsung Exynos Platform" > - depends on (ARCH_EXYNOS || COMPILE_TEST) && OF > + depends on (USB_DWC3 || COMPILE_TEST) && OF > default USB_DWC3 > help > - Recent Exynos5 SoCs ship with one DesignWare Core USB3 IP inside, > + Exynos SoCs chip with one DesignWare Core USB3 IP inside, This does not make much sense anymore, can you reword it? thanks, greg k-h
On Mon, 8 Feb 2021 at 12:51, taehyun cho <taehyun.cho@samsung.com> wrote: > > 'ARCH_EXYNOS' is no more used. 'USB_DWC3_EXYNOS' is glue layer As a maintainer of Samsung Exynos SoC, I am very surprised to hear that ARCH_EXYNOS is not used anymore... Quite contrary, in my opinion it is still used. You need to rephrase this sentence, because it's not possible to understand in current form. > which can be used with Synopsys DWC3 controller on Exynos SoCs. > 'USB_DWC3_EXYNOS' can be used from Exynos5 to Exynos9. Please provide here the answer to "why you want to remove ARCH_EXYNOS". Quite precise answer, please. In future, please Cc lists and people responsible for this drivers: scripts/get_maintainer.pl -f drivers/usb/dwc3/dwc3-exynos.c Best regards, Krzysztof
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 2133acf8ee69..dc2f92ac8ef6 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -67,10 +67,10 @@ config USB_DWC3_OMAP config USB_DWC3_EXYNOS tristate "Samsung Exynos Platform" - depends on (ARCH_EXYNOS || COMPILE_TEST) && OF + depends on (USB_DWC3 || COMPILE_TEST) && OF default USB_DWC3 help - Recent Exynos5 SoCs ship with one DesignWare Core USB3 IP inside, + Exynos SoCs chip with one DesignWare Core USB3 IP inside, say 'Y' or 'M' if you have one such device. config USB_DWC3_PCI
'ARCH_EXYNOS' is no more used. 'USB_DWC3_EXYNOS' is glue layer which can be used with Synopsys DWC3 controller on Exynos SoCs. 'USB_DWC3_EXYNOS' can be used from Exynos5 to Exynos9. Signed-off-by: taehyun cho <taehyun.cho@samsung.com> --- drivers/usb/dwc3/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)