| Message ID | 20210307154124.41651-1-aaron.dewes@web.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] Add unusal uas devices reported by Umbrel users | expand |
Hi, On 3/7/21 4:41 PM, Aaron Dewes wrote: > This patch adds more unusual UAS devices. > All these devices were reported by users of Umbrel, > and applying this patch fixed the issues. > > Signed-off-by: Aaron Dewes <aaron.dewes@web.de> NACK, see my reply to v1 of the patch. Regards, Hans > --- > drivers/usb/storage/unusual_uas.h | 70 +++++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index f9677a5ec31b..a67ed2b527fa 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -28,6 +28,27 @@ > * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org> > */ > > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x04e8, 0x4001, 0x0000, 0x9999, > + "Samsung", > + "SSD", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x04e8, 0x61b6, 0x0000, 0x9999, > + "Samsung", > + "M3 Portable Hard Drive", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x04e8, 0x61f5, 0x0000, 0x9999, > + "Samsung", > + "Portable SSD T5", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > /* Reported-by: Till Dörges <doerges@pre-sense.de> */ > UNUSUAL_DEV(0x054c, 0x087d, 0x0000, 0x9999, > "Sony", > @@ -62,6 +83,20 @@ UNUSUAL_DEV(0x0bc2, 0x331a, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_REPORT_LUNS), > > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x1058, 0x082a, 0x0000, 0x9999, > + "Western Digital", > + "SSD", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x125f, 0xa76a, 0x0000, 0x9999, > + "ADATA", > + "ED600 enclosure", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > /* Reported-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> */ > UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, > "Initio Corporation", > @@ -76,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0539, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_REPORT_OPCODES), > > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x152d, 0x0562, 0x0000, 0x9999, > + "JMicron", > + "JMS567", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > /* Reported-by: Claudio Bizzarri <claudio.bizzarri@gmail.com> */ > UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x9999, > "JMicron", > @@ -90,6 +132,20 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_BROKEN_FUA), > > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x152d, 0x1561, 0x0000, 0x9999, > + "JMicron", > + "JMS561U", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x152d, 0x1561, 0x0000, 0x9999, > + "JMicron", > + "External Disk connector", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > /* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */ > UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999, > "PNY", > @@ -104,6 +160,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_ATA_1X), > > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x174c, 0x55aa, 0x0000, 0x9999, > + "ASMedia", > + "ASM1051E and ASM1053E", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > + > /* Reported-by: Hans de Goede <hdegoede@redhat.com> */ > UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, > "VIA", > @@ -150,3 +213,10 @@ UNUSUAL_DEV(0x4971, 0x8024, 0x0000, 0x9999, > "External HDD", > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_ALWAYS_SYNC), > + > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x7825, 0xa2a4, 0x0000, 0x9999, > + "Other World Computing", > + "PA023U3", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > -- > 2.30.1 >
On Sun, Mar 07, 2021 at 04:41:24PM +0100, Aaron Dewes wrote: > This patch adds more unusual UAS devices. > All these devices were reported by users of Umbrel, > and applying this patch fixed the issues. > > Signed-off-by: Aaron Dewes <aaron.dewes@web.de> > --- > drivers/usb/storage/unusual_uas.h | 70 +++++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index f9677a5ec31b..a67ed2b527fa 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -28,6 +28,27 @@ > * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org> > */ > > +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ > +UNUSUAL_DEV(0x04e8, 0x4001, 0x0000, 0x9999, > + "Samsung", > + "SSD", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), With the IGNORE_UAS flag set, the uas driver will ignore these devices. In particular, it will ignore the NO_REPORT_OPCODES flag. So there's no reason to put that flag in these new entries. Alan Stern
diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index f9677a5ec31b..a67ed2b527fa 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -28,6 +28,27 @@ * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org> */ +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x04e8, 0x4001, 0x0000, 0x9999, + "Samsung", + "SSD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x04e8, 0x61b6, 0x0000, 0x9999, + "Samsung", + "M3 Portable Hard Drive", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x04e8, 0x61f5, 0x0000, 0x9999, + "Samsung", + "Portable SSD T5", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + /* Reported-by: Till Dörges <doerges@pre-sense.de> */ UNUSUAL_DEV(0x054c, 0x087d, 0x0000, 0x9999, "Sony", @@ -62,6 +83,20 @@ UNUSUAL_DEV(0x0bc2, 0x331a, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_REPORT_LUNS), +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x1058, 0x082a, 0x0000, 0x9999, + "Western Digital", + "SSD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x125f, 0xa76a, 0x0000, 0x9999, + "ADATA", + "ED600 enclosure", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + /* Reported-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> */ UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, "Initio Corporation", @@ -76,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0539, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_REPORT_OPCODES), +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x152d, 0x0562, 0x0000, 0x9999, + "JMicron", + "JMS567", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + /* Reported-by: Claudio Bizzarri <claudio.bizzarri@gmail.com> */ UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x9999, "JMicron", @@ -90,6 +132,20 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_BROKEN_FUA), +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x152d, 0x1561, 0x0000, 0x9999, + "JMicron", + "JMS561U", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x152d, 0x1561, 0x0000, 0x9999, + "JMicron", + "External Disk connector", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + /* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */ UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999, "PNY", @@ -104,6 +160,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x174c, 0x55aa, 0x0000, 0x9999, + "ASMedia", + "ASM1051E and ASM1053E", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), + /* Reported-by: Hans de Goede <hdegoede@redhat.com> */ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, "VIA", @@ -150,3 +213,10 @@ UNUSUAL_DEV(0x4971, 0x8024, 0x0000, 0x9999, "External HDD", USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_ALWAYS_SYNC), + +/* Reported-by: Aaron Dewes <aaron.dewes@web.de */ +UNUSUAL_DEV(0x7825, 0xa2a4, 0x0000, 0x9999, + "Other World Computing", + "PA023U3", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS),
This patch adds more unusual UAS devices. All these devices were reported by users of Umbrel, and applying this patch fixed the issues. Signed-off-by: Aaron Dewes <aaron.dewes@web.de> --- drivers/usb/storage/unusual_uas.h | 70 +++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) -- 2.30.1