| Message ID | 20210323153626.54908-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 91356fed6afd1c83bf0d3df1fc336d54e38f0458 |
| Headers | show |
| Series | [v2,1/7] usb: gadget: pch_udc: Replace cpu_to_le32() by lower_32_bits() | expand |
On Tue, Mar 23, 2021 at 4:36 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Either way ~0 will be in the correct byte order, hence > replace cpu_to_le32() by lower_32_bits(). Moreover, > it makes sparse happy, otherwise it complains: > > .../pch_udc.c:1813:27: warning: incorrect type in assignment (different base types) > .../pch_udc.c:1813:27: expected unsigned int [usertype] dataptr > .../pch_udc.c:1813:27: got restricted __le32 [usertype] > > Fixes: f646cf94520e ("USB device driver of Topcliff PCH") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Nice fix! Also easier to understand. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index a3c1fc924268..c517186384bc 100644 --- a/drivers/usb/gadget/udc/pch_udc.c +++ b/drivers/usb/gadget/udc/pch_udc.c @@ -1756,7 +1756,7 @@ static struct usb_request *pch_udc_alloc_request(struct usb_ep *usbep, } /* prevent from using desc. - set HOST BUSY */ dma_desc->status |= PCH_UDC_BS_HST_BSY; - dma_desc->dataptr = cpu_to_le32(DMA_ADDR_INVALID); + dma_desc->dataptr = lower_32_bits(DMA_ADDR_INVALID); req->td_data = dma_desc; req->td_data_last = dma_desc; req->chain_len = 1;
Either way ~0 will be in the correct byte order, hence replace cpu_to_le32() by lower_32_bits(). Moreover, it makes sparse happy, otherwise it complains: .../pch_udc.c:1813:27: warning: incorrect type in assignment (different base types) .../pch_udc.c:1813:27: expected unsigned int [usertype] dataptr .../pch_udc.c:1813:27: got restricted __le32 [usertype] Fixes: f646cf94520e ("USB device driver of Topcliff PCH") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: fixed 64-bit build (Greg) drivers/usb/gadget/udc/pch_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)