| Message ID | 20210406013643.3280369-4-badhri@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fixes for tcpm-source-psy- and pSnkStby | expand |
On 4/5/21 6:36 PM, Badhri Jagan Sridharan wrote: > power_supply_changed needs to be called to notify clients > after the partner accepts the requested values for the pps > case. > > Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through power_supply") > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > --- > drivers/usb/typec/tcpm/tcpm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index d43774cc2ccf..7708b01009cb 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -2564,6 +2564,7 @@ static void tcpm_pd_ctrl_request(struct tcpm_port *port, > port->pps_data.max_curr = port->pps_data.req_max_curr; > port->req_supply_voltage = port->pps_data.req_out_volt; > port->req_current_limit = port->pps_data.req_op_curr; > + power_supply_changed(port->psy); > tcpm_set_state(port, SNK_TRANSITION_SINK, 0); > break; > case SOFT_RESET_SEND: > @@ -3132,7 +3133,6 @@ static unsigned int tcpm_pd_select_pps_apdo(struct tcpm_port *port) > port->pps_data.req_out_volt)); > port->pps_data.req_op_curr = min(port->pps_data.max_curr, > port->pps_data.req_op_curr); > - power_supply_changed(port->psy); > } > > return src_pdo; > @@ -3557,8 +3557,6 @@ static void tcpm_reset_port(struct tcpm_port *port) > port->sink_cap_done = false; > if (port->tcpc->enable_frs) > port->tcpc->enable_frs(port->tcpc, false); > - > - power_supply_changed(port->psy); The reason for this change is missing in the patch description, or am I missing something ? Thanks, Guenter > } > > static void tcpm_detach(struct tcpm_port *port) >
On 06 April 2021 02:37, Badhri Jagan Sridharan wrote: > power_supply_changed needs to be called to notify clients > after the partner accepts the requested values for the pps > case. > > Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through > power_supply") > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > --- Missing commit information aside: Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> > drivers/usb/typec/tcpm/tcpm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index d43774cc2ccf..7708b01009cb 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -2564,6 +2564,7 @@ static void tcpm_pd_ctrl_request(struct tcpm_port > *port, > port->pps_data.max_curr = port- > >pps_data.req_max_curr; > port->req_supply_voltage = port- > >pps_data.req_out_volt; > port->req_current_limit = port->pps_data.req_op_curr; > + power_supply_changed(port->psy); > tcpm_set_state(port, SNK_TRANSITION_SINK, 0); > break; > case SOFT_RESET_SEND: > @@ -3132,7 +3133,6 @@ static unsigned int tcpm_pd_select_pps_apdo(struct > tcpm_port *port) > port- > >pps_data.req_out_volt)); > port->pps_data.req_op_curr = min(port->pps_data.max_curr, > port->pps_data.req_op_curr); > - power_supply_changed(port->psy); > } > > return src_pdo; > @@ -3557,8 +3557,6 @@ static void tcpm_reset_port(struct tcpm_port *port) > port->sink_cap_done = false; > if (port->tcpc->enable_frs) > port->tcpc->enable_frs(port->tcpc, false); > - > - power_supply_changed(port->psy); > } > > static void tcpm_detach(struct tcpm_port *port) > -- > 2.31.0.208.g409f899ff0-goog
>> The reason for this change is missing in the patch description, >> or am I missing something ? Ah yes forgot to state this in the commit description which I have updated in V2. Removed a redundant power_supply_changed as one was already made a couple of lines before this one. Thanks, Badhri On Wed, Apr 7, 2021 at 9:08 AM Adam Thomson <Adam.Thomson.Opensource@diasemi.com> wrote: > > On 06 April 2021 02:37, Badhri Jagan Sridharan wrote: > > > power_supply_changed needs to be called to notify clients > > after the partner accepts the requested values for the pps > > case. > > > > Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through > > power_supply") > > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > > --- > > Missing commit information aside: > > Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> > > > drivers/usb/typec/tcpm/tcpm.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > > index d43774cc2ccf..7708b01009cb 100644 > > --- a/drivers/usb/typec/tcpm/tcpm.c > > +++ b/drivers/usb/typec/tcpm/tcpm.c > > @@ -2564,6 +2564,7 @@ static void tcpm_pd_ctrl_request(struct tcpm_port > > *port, > > port->pps_data.max_curr = port- > > >pps_data.req_max_curr; > > port->req_supply_voltage = port- > > >pps_data.req_out_volt; > > port->req_current_limit = port->pps_data.req_op_curr; > > + power_supply_changed(port->psy); > > tcpm_set_state(port, SNK_TRANSITION_SINK, 0); > > break; > > case SOFT_RESET_SEND: > > @@ -3132,7 +3133,6 @@ static unsigned int tcpm_pd_select_pps_apdo(struct > > tcpm_port *port) > > port- > > >pps_data.req_out_volt)); > > port->pps_data.req_op_curr = min(port->pps_data.max_curr, > > port->pps_data.req_op_curr); > > - power_supply_changed(port->psy); > > } > > > > return src_pdo; > > @@ -3557,8 +3557,6 @@ static void tcpm_reset_port(struct tcpm_port *port) > > port->sink_cap_done = false; > > if (port->tcpc->enable_frs) > > port->tcpc->enable_frs(port->tcpc, false); > > - > > - power_supply_changed(port->psy); > > } > > > > static void tcpm_detach(struct tcpm_port *port) > > -- > > 2.31.0.208.g409f899ff0-goog >
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index d43774cc2ccf..7708b01009cb 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -2564,6 +2564,7 @@ static void tcpm_pd_ctrl_request(struct tcpm_port *port, port->pps_data.max_curr = port->pps_data.req_max_curr; port->req_supply_voltage = port->pps_data.req_out_volt; port->req_current_limit = port->pps_data.req_op_curr; + power_supply_changed(port->psy); tcpm_set_state(port, SNK_TRANSITION_SINK, 0); break; case SOFT_RESET_SEND: @@ -3132,7 +3133,6 @@ static unsigned int tcpm_pd_select_pps_apdo(struct tcpm_port *port) port->pps_data.req_out_volt)); port->pps_data.req_op_curr = min(port->pps_data.max_curr, port->pps_data.req_op_curr); - power_supply_changed(port->psy); } return src_pdo; @@ -3557,8 +3557,6 @@ static void tcpm_reset_port(struct tcpm_port *port) port->sink_cap_done = false; if (port->tcpc->enable_frs) port->tcpc->enable_frs(port->tcpc, false); - - power_supply_changed(port->psy); } static void tcpm_detach(struct tcpm_port *port)
power_supply_changed needs to be called to notify clients after the partner accepts the requested values for the pps case. Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through power_supply") Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> --- drivers/usb/typec/tcpm/tcpm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)