| Message ID | 20210408085033.909377-1-yebin10@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] usbip: vudc: fix missing unlock on error in usbip_sockfd_store() | expand |
这种bugfix最好加下Fixes tag On 2021/4/8 16:50, Ye Bin wrote: > Add the missing unlock before return from function usbip_sockfd_store() > in the error handling case. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Ye Bin <yebin10@huawei.com> > --- > drivers/usb/usbip/vudc_sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c > index f7633ee655a1..d1cf6b51bf85 100644 > --- a/drivers/usb/usbip/vudc_sysfs.c > +++ b/drivers/usb/usbip/vudc_sysfs.c > @@ -156,12 +156,14 @@ static ssize_t usbip_sockfd_store(struct device *dev, > tcp_rx = kthread_create(&v_rx_loop, &udc->ud, "vudc_rx"); > if (IS_ERR(tcp_rx)) { > sockfd_put(socket); > + mutex_unlock(&udc->ud.sysfs_lock); > return -EINVAL; > } > tcp_tx = kthread_create(&v_tx_loop, &udc->ud, "vudc_tx"); > if (IS_ERR(tcp_tx)) { > kthread_stop(tcp_rx); > sockfd_put(socket); > + mutex_unlock(&udc->ud.sysfs_lock); > return -EINVAL; > } > > > . >
On Thu, Apr 08, 2021 at 04:57:11PM +0800, YueHaibing wrote: > > 这种bugfix最好加下Fixes tag I am sorry but I can not parse that :(
On 2021/4/8 17:19, Greg Kroah-Hartman wrote: > On Thu, Apr 08, 2021 at 04:57:11PM +0800, YueHaibing wrote: >> >> 这种bugfix最好加下Fixes tag > > I am sorry but I can not parse that :( Sorry, I just suggest to add this Fixes tag Fixes: bd8b82042269 ("usbip: vudc synchronize sysfs code paths") > . >
On Thu, Apr 08, 2021 at 05:39:06PM +0800, YueHaibing wrote: > On 2021/4/8 17:19, Greg Kroah-Hartman wrote: > > On Thu, Apr 08, 2021 at 04:57:11PM +0800, YueHaibing wrote: > >> > >> 这种bugfix最好加下Fixes tag > > > > I am sorry but I can not parse that :( > > Sorry, I just suggest to add this Fixes tag > > Fixes: bd8b82042269 ("usbip: vudc synchronize sysfs code paths") Yes, that would be great to have added, thanks! greg k-h
diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c index f7633ee655a1..d1cf6b51bf85 100644 --- a/drivers/usb/usbip/vudc_sysfs.c +++ b/drivers/usb/usbip/vudc_sysfs.c @@ -156,12 +156,14 @@ static ssize_t usbip_sockfd_store(struct device *dev, tcp_rx = kthread_create(&v_rx_loop, &udc->ud, "vudc_rx"); if (IS_ERR(tcp_rx)) { sockfd_put(socket); + mutex_unlock(&udc->ud.sysfs_lock); return -EINVAL; } tcp_tx = kthread_create(&v_tx_loop, &udc->ud, "vudc_tx"); if (IS_ERR(tcp_tx)) { kthread_stop(tcp_rx); sockfd_put(socket); + mutex_unlock(&udc->ud.sysfs_lock); return -EINVAL; }
Add the missing unlock before return from function usbip_sockfd_store() in the error handling case. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Ye Bin <yebin10@huawei.com> --- drivers/usb/usbip/vudc_sysfs.c | 2 ++ 1 file changed, 2 insertions(+)