| Message ID | 20210409134033.105834-3-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 55d8b34772e0728a224198ba605eed8cfc570aa0 |
| Headers | show |
| Series | usb: typec: Add typec_port_register_altmodes() | expand |
On Fri, Apr 09, 2021 at 03:40:32PM +0200, Hans de Goede wrote: > Add support for altmodes described in the usb-connector fwnode > associated with the Type-C controller by calling the new > typec_port_register_altmodes_from_fwnode() helper for this. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index ce7af398c7c1..70a5d6ca0053 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -6072,6 +6072,10 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) > goto out_role_sw_put; > } > > + typec_port_register_altmodes(port->typec_port, > + &tcpm_altmode_ops, port, > + port->port_altmode, ALTMODE_DISCOVERY_MAX); > + > mutex_lock(&port->lock); > tcpm_init(port); > mutex_unlock(&port->lock); > -- > 2.30.2
On 4/9/21 6:40 AM, Hans de Goede wrote: > Add support for altmodes described in the usb-connector fwnode > associated with the Type-C controller by calling the new > typec_port_register_altmodes_from_fwnode() helper for this. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/usb/typec/tcpm/tcpm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index ce7af398c7c1..70a5d6ca0053 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -6072,6 +6072,10 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) > goto out_role_sw_put; > } > > + typec_port_register_altmodes(port->typec_port, > + &tcpm_altmode_ops, port, > + port->port_altmode, ALTMODE_DISCOVERY_MAX); > + > mutex_lock(&port->lock); > tcpm_init(port); > mutex_unlock(&port->lock); >
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index ce7af398c7c1..70a5d6ca0053 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -6072,6 +6072,10 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) goto out_role_sw_put; } + typec_port_register_altmodes(port->typec_port, + &tcpm_altmode_ops, port, + port->port_altmode, ALTMODE_DISCOVERY_MAX); + mutex_lock(&port->lock); tcpm_init(port); mutex_unlock(&port->lock);
Add support for altmodes described in the usb-connector fwnode associated with the Type-C controller by calling the new typec_port_register_altmodes_from_fwnode() helper for this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/usb/typec/tcpm/tcpm.c | 4 ++++ 1 file changed, 4 insertions(+)