| Message ID | 20210410024818.65659-1-cuibixuan@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dc1e7e9a27e05260c45e142d28fb56ae63f94966 |
| Headers | show |
| Series | [-next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe() | expand |
Bixuan Cui <cuibixuan@huawei.com> writes: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> Acked-by: Felipe Balbi <balbi@kernel.org>
On Fri 09 Apr 21:48 CDT 2021, Bixuan Cui wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/usb/dwc3/dwc3-qcom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index e37cc58dfa55..726d5048d87c 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -774,7 +774,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > > qcom->qscratch_base = devm_ioremap_resource(dev, parent_res); > if (IS_ERR(qcom->qscratch_base)) { > - dev_err(dev, "failed to map qscratch, err=%d\n", ret); > ret = PTR_ERR(qcom->qscratch_base); > goto clk_disable; > } >
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index e37cc58dfa55..726d5048d87c 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -774,7 +774,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev) qcom->qscratch_base = devm_ioremap_resource(dev, parent_res); if (IS_ERR(qcom->qscratch_base)) { - dev_err(dev, "failed to map qscratch, err=%d\n", ret); ret = PTR_ERR(qcom->qscratch_base); goto clk_disable; }
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com> --- drivers/usb/dwc3/dwc3-qcom.c | 1 - 1 file changed, 1 deletion(-)