| Message ID | 20210928111639.3854174-1-xu.yang_2@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6d91017a295e9790eec02c4e43f020cdb55f5d98 |
| Headers | show |
| Series | usb: typec: tcpm: handle SRC_STARTUP state if cc changes | expand |
On Tue, Sep 28, 2021 at 07:16:39PM +0800, Xu Yang wrote: > TCPM for DRP should do the same action as SRC_ATTACHED when cc changes in > SRC_STARTUP state. Otherwise, TCPM will transition to SRC_UNATTACHED state > which is not satisfied with the Type-C spec. > > Per Type-C spec: > DRP port should move to Unattached.SNK instead of Unattached.SRC if sink > removed. > > Fixes: 4b4e02c83167 ("typec: tcpm: Move out of staging") > cc: <stable@vger.kernel.org> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/usb/typec/tcpm/tcpm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index a4d37205df54..7f2f3ff1b391 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -4876,6 +4876,7 @@ static void _tcpm_cc_change(struct tcpm_port *port, enum typec_cc_status cc1, > tcpm_set_state(port, SRC_ATTACH_WAIT, 0); > break; > case SRC_ATTACHED: > + case SRC_STARTUP: > case SRC_SEND_CAPABILITIES: > case SRC_READY: > if (tcpm_port_is_disconnected(port) || > -- > 2.25.1 >
On Tue, Sep 28, 2021 at 07:16:39PM +0800, Xu Yang wrote: > TCPM for DRP should do the same action as SRC_ATTACHED when cc changes in > SRC_STARTUP state. Otherwise, TCPM will transition to SRC_UNATTACHED state > which is not satisfied with the Type-C spec. > > Per Type-C spec: > DRP port should move to Unattached.SNK instead of Unattached.SRC if sink > removed. > > Fixes: 4b4e02c83167 ("typec: tcpm: Move out of staging") > cc: <stable@vger.kernel.org> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index a4d37205df54..7f2f3ff1b391 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -4876,6 +4876,7 @@ static void _tcpm_cc_change(struct tcpm_port *port, enum typec_cc_status cc1, > tcpm_set_state(port, SRC_ATTACH_WAIT, 0); > break; > case SRC_ATTACHED: > + case SRC_STARTUP: > case SRC_SEND_CAPABILITIES: > case SRC_READY: > if (tcpm_port_is_disconnected(port) || > -- > 2.25.1
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index a4d37205df54..7f2f3ff1b391 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -4876,6 +4876,7 @@ static void _tcpm_cc_change(struct tcpm_port *port, enum typec_cc_status cc1, tcpm_set_state(port, SRC_ATTACH_WAIT, 0); break; case SRC_ATTACHED: + case SRC_STARTUP: case SRC_SEND_CAPABILITIES: case SRC_READY: if (tcpm_port_is_disconnected(port) ||
TCPM for DRP should do the same action as SRC_ATTACHED when cc changes in SRC_STARTUP state. Otherwise, TCPM will transition to SRC_UNATTACHED state which is not satisfied with the Type-C spec. Per Type-C spec: DRP port should move to Unattached.SNK instead of Unattached.SRC if sink removed. Fixes: 4b4e02c83167 ("typec: tcpm: Move out of staging") cc: <stable@vger.kernel.org> Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- drivers/usb/typec/tcpm/tcpm.c | 1 + 1 file changed, 1 insertion(+)