| Message ID | 20210929090937.7410-3-johan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 58fc1daa4d2e9789b9ffc880907c961ea7c062cc |
| Headers | show |
| Series | USB: cdc-acm: fix break reporting | expand |
On 29.09.21 11:09, Johan Hovold wrote: > A recent change that started reporting break events forgot to push the > event to the line discipline, which meant that a detected break would > not be reported until further characters had been receive (the port > could even have been closed and reopened in between). > > Fixes: 08dff274edda ("cdc-acm: fix BREAK rx code path adding necessary calls") > Cc: stable@vger.kernel.org > Signed-off-by: Johan Hovold <johan@kernel.org> Acked-by: Oliver Neukum <oneukum@suse.com>
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index c7a1736720e7..7b2e2420ecae 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -340,6 +340,9 @@ static void acm_process_notification(struct acm *acm, unsigned char *buf) acm->iocount.overrun++; spin_unlock_irqrestore(&acm->read_lock, flags); + if (newctrl & ACM_CTRL_BRK) + tty_flip_buffer_push(&acm->port); + if (difference) wake_up_all(&acm->wioctl);
A recent change that started reporting break events forgot to push the event to the line discipline, which meant that a detected break would not be reported until further characters had been receive (the port could even have been closed and reopened in between). Fixes: 08dff274edda ("cdc-acm: fix BREAK rx code path adding necessary calls") Cc: stable@vger.kernel.org Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/usb/class/cdc-acm.c | 3 +++ 1 file changed, 3 insertions(+)