diff mbox series

[v2] usb: host: ohci-tmio: check return value after calling platform_get_resource()

Message ID 20211011134920.118477-1-yangyingliang@huawei.com (mailing list archive)
State Accepted
Commit 9eff2b2e59fda25051ab36cd1cb5014661df657b
Headers show
Series [v2] usb: host: ohci-tmio: check return value after calling platform_get_resource() | expand

Commit Message

Yang Yingliang Oct. 11, 2021, 1:49 p.m. UTC 
It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
v2:
  combine the new checkings with cell checking
---
 drivers/usb/host/ohci-tmio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
index 08ec2ab0d95a..3f3d62dc0674 100644
--- a/drivers/usb/host/ohci-tmio.c
+++ b/drivers/usb/host/ohci-tmio.c
@@ -199,7 +199,7 @@  static int ohci_hcd_tmio_drv_probe(struct platform_device *dev)
 	if (usb_disabled())
 		return -ENODEV;
 
-	if (!cell)
+	if (!cell || !regs || !config || !sram)
 		return -EINVAL;
 
 	if (irq < 0)