| Message ID | 20211127104707.2546-1-schuchmann@schleissheimer.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 817b653160db9852d5a0498a31f047e18ce27e5b |
| Headers | show |
| Series | [v2] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Sat, 27 Nov 2021 11:47:07 +0100 you wrote: > On most systems request for IRQ 0 will fail, phylib will print an error message > and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ > is available. > > Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de> > > [...] Here is the summary with links: - [v2] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available https://git.kernel.org/netdev/net/c/817b653160db You are awesome, thank you!
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 2bfb59ae0eaf..185e08c1af31 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2398,7 +2398,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) if (dev->domain_data.phyirq > 0) phydev->irq = dev->domain_data.phyirq; else - phydev->irq = 0; + phydev->irq = PHY_POLL; netdev_dbg(dev->net, "phydev->irq = %d\n", phydev->irq); /* set to AUTOMDIX */
On most systems request for IRQ 0 will fail, phylib will print an error message and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ is available. Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de> --- Changes v1->v2: Added "Fixes" and "Reviewed-by" --- drivers/net/usb/lan78xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)