| Message ID | 20211220134244.930727-1-jiasheng@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] USB: host: Check for null res pointer | expand |
On 12/20/21 4:42 PM, Jiasheng Jiang wrote: > The return value of platform_get_resource() needs to be checked. > To avoid use of error pointer in case that there is no suitable resource. s/error/NULL/ -- platform_get_resource() doesn't return error pointers... > Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> [...] MBR, Sergey
And the subject should look like "usb: host: isp116x: check for NULL pointer".
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 8835f6bd528e..addd2b43a14c 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1541,9 +1541,15 @@ static int isp116x_remove(struct platform_device *pdev) iounmap(isp116x->data_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); + if (!res) + return -ENODEV; + release_mem_region(res->start, 2); iounmap(isp116x->addr_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -ENODEV; + release_mem_region(res->start, 2); usb_put_hcd(hcd);
The return value of platform_get_resource() needs to be checked. To avoid use of error pointer in case that there is no suitable resource. Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- Changelog: v2 -> v3 *Change 1. Correct the commit message. *CHange 2. Change the return code. --- drivers/usb/host/isp116x-hcd.c | 6 ++++++ 1 file changed, 6 insertions(+)