| Message ID | 20220105151427.8373-2-aaron.ma@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3,v3] net: usb: r8152: Check used MAC passthrough address | expand |
On Wed, Jan 05, 2022 at 11:14:26PM +0800, Aaron Ma wrote: > To avoid the race of get passthrough MAC, > set probe mode to sync to check the used MAC address. > > Signed-off-by: Aaron Ma <aaron.ma@canonical.com> > --- > drivers/net/usb/r8152.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 2483dc421dff..7cf2faf8d088 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -29,6 +29,8 @@ > #include <crypto/hash.h> > #include <linux/usb/r8152.h> > > +static struct usb_driver rtl8152_driver; > + > /* Information for net-next */ > #define NETNEXT_VERSION "12" > > @@ -9546,6 +9548,9 @@ static int rtl8152_probe(struct usb_interface *intf, > struct r8152 *tp; > struct net_device *netdev; > int ret; > + struct device_driver *rtl8152_drv = &rtl8152_driver.drvwrap.driver; > + > + rtl8152_drv->probe_type = PROBE_FORCE_SYNCHRONOUS; If you really need to set this type of thing then set BEFORE you register the driver. After-the-fact like this is way too late, sorry. You are already in the probe function which is after the driver core checked this flag :( How did you test this? thanks, greg k-h
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 2483dc421dff..7cf2faf8d088 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -29,6 +29,8 @@ #include <crypto/hash.h> #include <linux/usb/r8152.h> +static struct usb_driver rtl8152_driver; + /* Information for net-next */ #define NETNEXT_VERSION "12" @@ -9546,6 +9548,9 @@ static int rtl8152_probe(struct usb_interface *intf, struct r8152 *tp; struct net_device *netdev; int ret; + struct device_driver *rtl8152_drv = &rtl8152_driver.drvwrap.driver; + + rtl8152_drv->probe_type = PROBE_FORCE_SYNCHRONOUS; if (version == RTL_VER_UNKNOWN) return -ENODEV;
To avoid the race of get passthrough MAC, set probe mode to sync to check the used MAC address. Signed-off-by: Aaron Ma <aaron.ma@canonical.com> --- drivers/net/usb/r8152.c | 5 +++++ 1 file changed, 5 insertions(+)