| Message ID | 20220220131339.179648-1-ahamedhusni73@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] usb: serial: Fix Space Prohibited Coding Style Errors | expand |
On Sun, Feb 20, 2022 at 06:43:39PM +0530, Husni Faiz wrote: > This patch fixes "space prohibited before that ','" checkpatch error. > Removed the space after the function argument value "8". > > Signed-off-by: Husni Faiz <ahamedhusni73@gmail.com> > --- > V1->V2 : Separated the style changes into multiple patches. As Greg mentioned, please work in drivers/staging if you want to submit these kind of patches. checkpatch.pl is great for checking your own patches before submission, but it shouldn't be run on code that's already in the tree, and where fixing a white space issue like this one has essentially no value. And as your staging/greybus submission showed, using the output of tools like checkpatch.pl even risks breaking things if you take it too literally and don't use your own judgement. > drivers/usb/serial/iuu_phoenix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c > index 0be3b5e1eaf3..2f7784572c4d 100644 > --- a/drivers/usb/serial/iuu_phoenix.c > +++ b/drivers/usb/serial/iuu_phoenix.c > @@ -360,7 +360,7 @@ static void iuu_led_activity_on(struct urb *urb) > usb_fill_bulk_urb(port->write_urb, port->serial->dev, > usb_sndbulkpipe(port->serial->dev, > port->bulk_out_endpointAddress), > - port->write_urb->transfer_buffer, 8 , > + port->write_urb->transfer_buffer, 8, > iuu_rxcmd, port); > usb_submit_urb(port->write_urb, GFP_ATOMIC); > } > @@ -380,7 +380,7 @@ static void iuu_led_activity_off(struct urb *urb) > usb_fill_bulk_urb(port->write_urb, port->serial->dev, > usb_sndbulkpipe(port->serial->dev, > port->bulk_out_endpointAddress), > - port->write_urb->transfer_buffer, 8 , > + port->write_urb->transfer_buffer, 8, > iuu_rxcmd, port); > usb_submit_urb(port->write_urb, GFP_ATOMIC); > } Johan
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c index 0be3b5e1eaf3..2f7784572c4d 100644 --- a/drivers/usb/serial/iuu_phoenix.c +++ b/drivers/usb/serial/iuu_phoenix.c @@ -360,7 +360,7 @@ static void iuu_led_activity_on(struct urb *urb) usb_fill_bulk_urb(port->write_urb, port->serial->dev, usb_sndbulkpipe(port->serial->dev, port->bulk_out_endpointAddress), - port->write_urb->transfer_buffer, 8 , + port->write_urb->transfer_buffer, 8, iuu_rxcmd, port); usb_submit_urb(port->write_urb, GFP_ATOMIC); } @@ -380,7 +380,7 @@ static void iuu_led_activity_off(struct urb *urb) usb_fill_bulk_urb(port->write_urb, port->serial->dev, usb_sndbulkpipe(port->serial->dev, port->bulk_out_endpointAddress), - port->write_urb->transfer_buffer, 8 , + port->write_urb->transfer_buffer, 8, iuu_rxcmd, port); usb_submit_urb(port->write_urb, GFP_ATOMIC); }
This patch fixes "space prohibited before that ','" checkpatch error. Removed the space after the function argument value "8". Signed-off-by: Husni Faiz <ahamedhusni73@gmail.com> --- V1->V2 : Separated the style changes into multiple patches. drivers/usb/serial/iuu_phoenix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)