diff mbox series

usb: gadget: rndis: prevent integer overflow in rndis_set_response()

Message ID 20220301080424.GA17208@kili (mailing list archive)
State Accepted
Commit 65f3324f4b6fed78b8761c3b74615ecf0ffa81fa
Headers show
Series usb: gadget: rndis: prevent integer overflow in rndis_set_response() | expand

Commit Message

Dan Carpenter March 1, 2022, 8:04 a.m. UTC 
If "BufOffset" is very large the "BufOffset + 8" operation can have an
integer overflow.

Fixes: 38ea1eac7d88 ("usb: gadget: rndis: check size of RNDIS_MSG_SET command")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/usb/gadget/function/rndis.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
index 00b3f6b3bb31..713efd9aefde 100644
--- a/drivers/usb/gadget/function/rndis.c
+++ b/drivers/usb/gadget/function/rndis.c
@@ -640,6 +640,7 @@  static int rndis_set_response(struct rndis_params *params,
 	BufLength = le32_to_cpu(buf->InformationBufferLength);
 	BufOffset = le32_to_cpu(buf->InformationBufferOffset);
 	if ((BufLength > RNDIS_MAX_TOTAL_SIZE) ||
+	    (BufOffset > RNDIS_MAX_TOTAL_SIZE) ||
 	    (BufOffset + 8 >= RNDIS_MAX_TOTAL_SIZE))
 		    return -EINVAL;