diff mbox series

[-next,v2] usb: xhci: tegra:Fix PM usage reference leak of tegra_xusb_unpowergate_partitions

Message ID 20220319023822.145641-1-zhangqilong3@huawei.com (mailing list archive)
State Accepted
Commit 8771039482d965bdc8cefd972bcabac2b76944a8
Headers show
Series [-next,v2] usb: xhci: tegra:Fix PM usage reference leak of tegra_xusb_unpowergate_partitions | expand

Commit Message

Zhang Qilong March 19, 2022, 2:38 a.m. UTC 
From: zhangqilong <zhangqilong3@huawei.com>

pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.

Fixes:41a7426d25fa3 ("usb: xhci: tegra: Unlink power domain devices")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
v2:
- Fix commit id
---
 drivers/usb/host/xhci-tegra.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index c8af2cd2216d..996958a6565c 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -1034,13 +1034,13 @@  static int tegra_xusb_unpowergate_partitions(struct tegra_xusb *tegra)
 	int rc;
 
 	if (tegra->use_genpd) {
-		rc = pm_runtime_get_sync(tegra->genpd_dev_ss);
+		rc = pm_runtime_resume_and_get(tegra->genpd_dev_ss);
 		if (rc < 0) {
 			dev_err(dev, "failed to enable XUSB SS partition\n");
 			return rc;
 		}
 
-		rc = pm_runtime_get_sync(tegra->genpd_dev_host);
+		rc = pm_runtime_resume_and_get(tegra->genpd_dev_host);
 		if (rc < 0) {
 			dev_err(dev, "failed to enable XUSB Host partition\n");
 			pm_runtime_put_sync(tegra->genpd_dev_ss);