| Message ID | 20220407102108.24211-4-jmaselbas@kalray.eu (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1599069a62c6179fdde9f6e5b54d44531064a79c |
| Headers | show |
| Series | Cleanup the call ordering of phy_init and phy_power_on | expand |
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index d11b517e283a..90f589563a60 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -253,6 +253,9 @@ int phy_init(struct phy *phy) ret = 0; /* Override possible ret == -ENOTSUPP */ mutex_lock(&phy->mutex); + if (phy->power_count > phy->init_count) + dev_warn(&phy->dev, "phy_power_on was called before phy_init\n"); + if (phy->init_count == 0 && phy->ops->init) { ret = phy->ops->init(phy); if (ret < 0) {
A warning when the order of phy operation is mixed up by drivers, this is an atempt to make the phy usage more uniform across (usb) drivers. Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de> Cc: Amelie DELAUNAY <amelie.delaunay@foss.st.com> Cc: Minas Harutyunyan <hminas@synopsys.com> Cc: Kishon Vijay Abraham I <kishon@ti.com> --- drivers/phy/phy-core.c | 3 +++ 1 file changed, 3 insertions(+)