| Message ID | 20220418082425.41566-1-renzhijie2@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9e3d68f872e4f5ce40dcc5baba7e37ab7961ed74 |
| Headers | show |
| Series | [-next] usb: typec: rt1719: Fix build error without CONFIG_POWER_SUPPLY | expand |
Mon, Apr 18, 2022 at 04:24:25PM +0800, Ren Zhijie kirjoitti: > Building without CONFIG_POWER_SUPPLY will fail: > > drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property': > rt1719.c:(.text+0x10a): undefined reference to `power_supply_get_drvdata' > drivers/usb/typec/rt1719.o: In function `rt1719_psy_get_property': > rt1719.c:(.text+0x2c8): undefined reference to `power_supply_get_drvdata' > drivers/usb/typec/rt1719.o: In function `devm_rt1719_psy_register': > rt1719.c:(.text+0x3e9): undefined reference to `devm_power_supply_register' > drivers/usb/typec/rt1719.o: In function `rt1719_irq_handler': > rt1719.c:(.text+0xf9f): undefined reference to `power_supply_changed' > drivers/usb/typec/rt1719.o: In function `rt1719_update_pwr_opmode.part.9': > rt1719.c:(.text+0x657): undefined reference to `power_supply_changed' > drivers/usb/typec/rt1719.o: In function `rt1719_attach': > rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed' > > Add POWER_SUPPLY dependency to Kconfig. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index 8f921213b17d..ba24847fb245 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -56,6 +56,7 @@ config TYPEC_RT1719 > tristate "Richtek RT1719 Sink Only Type-C controller driver" > depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > depends on I2C > + depends on POWER_SUPPLY > select REGMAP_I2C > help > Say Y or M here if your system has Richtek RT1719 sink only > -- > 2.17.1
ping... 在 2022/4/18 16:24, Ren Zhijie 写道: > Building without CONFIG_POWER_SUPPLY will fail: > > drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property': > rt1719.c:(.text+0x10a): undefined reference to `power_supply_get_drvdata' > drivers/usb/typec/rt1719.o: In function `rt1719_psy_get_property': > rt1719.c:(.text+0x2c8): undefined reference to `power_supply_get_drvdata' > drivers/usb/typec/rt1719.o: In function `devm_rt1719_psy_register': > rt1719.c:(.text+0x3e9): undefined reference to `devm_power_supply_register' > drivers/usb/typec/rt1719.o: In function `rt1719_irq_handler': > rt1719.c:(.text+0xf9f): undefined reference to `power_supply_changed' > drivers/usb/typec/rt1719.o: In function `rt1719_update_pwr_opmode.part.9': > rt1719.c:(.text+0x657): undefined reference to `power_supply_changed' > drivers/usb/typec/rt1719.o: In function `rt1719_attach': > rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed' > > Add POWER_SUPPLY dependency to Kconfig. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index 8f921213b17d..ba24847fb245 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -56,6 +56,7 @@ config TYPEC_RT1719 > tristate "Richtek RT1719 Sink Only Type-C controller driver" > depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > depends on I2C > + depends on POWER_SUPPLY > select REGMAP_I2C > help > Say Y or M here if your system has Richtek RT1719 sink only
於 三，2022-04-20 於 12:06 +0300，Heikki Krogerus 提到： > Mon, Apr 18, 2022 at 04:24:25PM +0800, Ren Zhijie kirjoitti: > > > > Building without CONFIG_POWER_SUPPLY will fail: > > > > drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property': > > rt1719.c:(.text+0x10a): undefined reference to `power_supply_get_drvdata' > > drivers/usb/typec/rt1719.o: In function `rt1719_psy_get_property': > > rt1719.c:(.text+0x2c8): undefined reference to `power_supply_get_drvdata' > > drivers/usb/typec/rt1719.o: In function `devm_rt1719_psy_register': > > rt1719.c:(.text+0x3e9): undefined reference to `devm_power_supply_register' > > drivers/usb/typec/rt1719.o: In function `rt1719_irq_handler': > > rt1719.c:(.text+0xf9f): undefined reference to `power_supply_changed' > > drivers/usb/typec/rt1719.o: In function `rt1719_update_pwr_opmode.part.9': > > rt1719.c:(.text+0x657): undefined reference to `power_supply_changed' > > drivers/usb/typec/rt1719.o: In function `rt1719_attach': > > rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed' > > > > Add POWER_SUPPLY dependency to Kconfig. Thanks. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Fixes: 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719") > > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: ChiYuan Huang <cy_huang@richtek.com> --- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index 8f921213b17d..ba24847fb245 100644 --- a/drivers/usb/typec/Kconfig +++ b/drivers/usb/typec/Kconfig @@ -56,6 +56,7 @@ config TYPEC_RT1719 tristate "Richtek RT1719 Sink Only Type-C controller driver" depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH depends on I2C +depends on POWER_SUPPLY select REGMAP_I2C help Say Y or M here if your system has Richtek RT1719 sink only -- 2.17.1 ************* Email Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
On Wed, Apr 20, 2022 at 12:06:36PM +0300, Heikki Krogerus wrote: > Mon, Apr 18, 2022 at 04:24:25PM +0800, Ren Zhijie kirjoitti: > > Building without CONFIG_POWER_SUPPLY will fail: > > > > drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property': > > rt1719.c:(.text+0x10a): undefined reference to `power_supply_get_drvdata' > > drivers/usb/typec/rt1719.o: In function `rt1719_psy_get_property': > > rt1719.c:(.text+0x2c8): undefined reference to `power_supply_get_drvdata' > > drivers/usb/typec/rt1719.o: In function `devm_rt1719_psy_register': > > rt1719.c:(.text+0x3e9): undefined reference to `devm_power_supply_register' > > drivers/usb/typec/rt1719.o: In function `rt1719_irq_handler': > > rt1719.c:(.text+0xf9f): undefined reference to `power_supply_changed' > > drivers/usb/typec/rt1719.o: In function `rt1719_update_pwr_opmode.part.9': > > rt1719.c:(.text+0x657): undefined reference to `power_supply_changed' > > drivers/usb/typec/rt1719.o: In function `rt1719_attach': > > rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed' > > > > Add POWER_SUPPLY dependency to Kconfig. > > Thanks. > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Fixes: 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719") > > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> > > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Reviewed-by: ChiYuan Huang <cy_huang@richtek.com> > > --- > > drivers/usb/typec/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > > index 8f921213b17d..ba24847fb245 100644 > > --- a/drivers/usb/typec/Kconfig > > +++ b/drivers/usb/typec/Kconfig > > @@ -56,6 +56,7 @@ config TYPEC_RT1719 > > tristate "Richtek RT1719 Sink Only Type-C controller driver" > > depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > > depends on I2C > > + depends on POWER_SUPPLY > > select REGMAP_I2C > > help > > Say Y or M here if your system has Richtek RT1719 sink only > > -- > > 2.17.1 > > -- > heikki
On Thu, Apr 21, 2022 at 08:46:39AM +0800, Ren Zhijie wrote: > ping... > > 在 2022/4/18 16:24, Ren Zhijie 写道: It was posted 3 days prior, relax please. If you are eager to see patches reviewed faster, please help out and review them on the lists, we can always use the help. thanks, greg k-h
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index 8f921213b17d..ba24847fb245 100644 --- a/drivers/usb/typec/Kconfig +++ b/drivers/usb/typec/Kconfig @@ -56,6 +56,7 @@ config TYPEC_RT1719 tristate "Richtek RT1719 Sink Only Type-C controller driver" depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH depends on I2C + depends on POWER_SUPPLY select REGMAP_I2C help Say Y or M here if your system has Richtek RT1719 sink only
Building without CONFIG_POWER_SUPPLY will fail: drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property': rt1719.c:(.text+0x10a): undefined reference to `power_supply_get_drvdata' drivers/usb/typec/rt1719.o: In function `rt1719_psy_get_property': rt1719.c:(.text+0x2c8): undefined reference to `power_supply_get_drvdata' drivers/usb/typec/rt1719.o: In function `devm_rt1719_psy_register': rt1719.c:(.text+0x3e9): undefined reference to `devm_power_supply_register' drivers/usb/typec/rt1719.o: In function `rt1719_irq_handler': rt1719.c:(.text+0xf9f): undefined reference to `power_supply_changed' drivers/usb/typec/rt1719.o: In function `rt1719_update_pwr_opmode.part.9': rt1719.c:(.text+0x657): undefined reference to `power_supply_changed' drivers/usb/typec/rt1719.o: In function `rt1719_attach': rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed' Add POWER_SUPPLY dependency to Kconfig. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719") Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> --- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)