| Message ID | 20220419110553.2574548-1-chi.minghao@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | USB: using pm_runtime_resume_and_get instead of pm_runtime_get_sync | expand |
On Tue, 2022-04-19 at 11:05 +0000, cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and > pm_runtime_put_noidle. This change is just to simplify the code, no > actual functional changes. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> Reviewed-by: Bastien Nocera <hadess@hadess.net> Thanks! > --- > drivers/usb/misc/apple-mfi-fastcharge.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c > b/drivers/usb/misc/apple-mfi-fastcharge.c > index ac8695195c13..fba102245d8f 100644 > --- a/drivers/usb/misc/apple-mfi-fastcharge.c > +++ b/drivers/usb/misc/apple-mfi-fastcharge.c > @@ -119,11 +119,9 @@ static int apple_mfi_fc_set_property(struct > power_supply *psy, > > dev_dbg(&mfi->udev->dev, "prop: %d\n", psp); > > - ret = pm_runtime_get_sync(&mfi->udev->dev); > - if (ret < 0) { > - pm_runtime_put_noidle(&mfi->udev->dev); > + ret = pm_runtime_resume_and_get(&mfi->udev->dev); > + if (ret < 0) > return ret; > - } > > switch (psp) { > case POWER_SUPPLY_PROP_CHARGE_TYPE:
diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c b/drivers/usb/misc/apple-mfi-fastcharge.c index ac8695195c13..fba102245d8f 100644 --- a/drivers/usb/misc/apple-mfi-fastcharge.c +++ b/drivers/usb/misc/apple-mfi-fastcharge.c @@ -119,11 +119,9 @@ static int apple_mfi_fc_set_property(struct power_supply *psy, dev_dbg(&mfi->udev->dev, "prop: %d\n", psp); - ret = pm_runtime_get_sync(&mfi->udev->dev); - if (ret < 0) { - pm_runtime_put_noidle(&mfi->udev->dev); + ret = pm_runtime_resume_and_get(&mfi->udev->dev); + if (ret < 0) return ret; - } switch (psp) { case POWER_SUPPLY_PROP_CHARGE_TYPE: