| Message ID | 20220425171412.1188485-2-sean.anderson@seco.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: phy: generic: Support enabling/disabling VBUS | expand |
On Mon, Apr 25, 2022 at 7:14 PM Sean Anderson <sean.anderson@seco.com> wrote: > The vbus-regulator property was never actually read from the device tree. > Introduce a new property vbus-supply to represent the regulator powering > the VBUS when acting as an A-Device. This supply will be enabled and > disabled as necessary. Note that this is different from vbus-regulator, > which represented the available current available to draw from VBUS in > B-Device mode. Because no one was using vbus-regulator, remove it. > > Signed-off-by: Sean Anderson <sean.anderson@seco.com> (...) > + vbus-supply: > + description: regulator supplying VBUS. It will be enabled and disabled > + dynamically in OTG mode. I would add a small text snippet like this: "If the regulator is controlled by a GPIO line, this should be modeled as a regulator-fixed and referenced by this supply" - it's helpful because otherwise people tend to start to submit weird stuff like adding yet another GPIO for this. Either way: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml index 2824c17285ee..b4517b01616f 100644 --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml @@ -34,10 +34,9 @@ properties: description: Should specify the GPIO detecting a VBus insertion maxItems: 1 - vbus-regulator: - description: Should specifiy the regulator supplying current drawn from - the VBus line. - $ref: /schemas/types.yaml#/definitions/phandle + vbus-supply: + description: regulator supplying VBUS. It will be enabled and disabled + dynamically in OTG mode. required: - compatible @@ -57,7 +56,7 @@ examples: vcc-supply = <&hsusb1_vcc_regulator>; reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>; vbus-detect-gpio = <&gpio2 13 GPIO_ACTIVE_HIGH>; - vbus-regulator = <&vbus_regulator>; + vbus-supply = <&vbus_regulator>; #phy-cells = <0>; };
The vbus-regulator property was never actually read from the device tree. Introduce a new property vbus-supply to represent the regulator powering the VBUS when acting as an A-Device. This supply will be enabled and disabled as necessary. Note that this is different from vbus-regulator, which represented the available current available to draw from VBUS in B-Device mode. Because no one was using vbus-regulator, remove it. Signed-off-by: Sean Anderson <sean.anderson@seco.com> --- Changes in v2: - Fix dt_binding_check errors Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)