diff mbox series

usb: ehci-omap: drop unused ehci_read() function

Message ID 20220428102314.950323-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 0cb46f8c7c72cb56badcf1f6b5f0ba1138a0f98c
Headers show
Series usb: ehci-omap: drop unused ehci_read() function | expand

Commit Message

Arnd Bergmann April 28, 2022, 10:22 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

After moving the omap1 platform into generalized multiplatform
support on ARM, the kernel test robot points out a W=1 warning that
now shows up in more configurations:

drivers/usb/host/ehci-omap.c:64:19: warning: unused function 'ehci_read'

The function was last used 9 years ago and can just be removed.

Fixes: 87425ad36330 ("USB: ehci-omap: Remove PHY reset handling code")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/host/ehci-omap.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Alan Stern April 28, 2022, 6:08 p.m. UTC | #1 
On Thu, Apr 28, 2022 at 12:22:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> After moving the omap1 platform into generalized multiplatform
> support on ARM, the kernel test robot points out a W=1 warning that
> now shows up in more configurations:
> 
> drivers/usb/host/ehci-omap.c:64:19: warning: unused function 'ehci_read'
> 
> The function was last used 9 years ago and can just be removed.
> 
> Fixes: 87425ad36330 ("USB: ehci-omap: Remove PHY reset handling code")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Acked-by: Alan Stern <stern@rowland.harvard.edu>
diff mbox series

Patch

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 7f4a03e8647a..8c45bc17a580 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -61,11 +61,6 @@  static inline void ehci_write(void __iomem *base, u32 reg, u32 val)
 	__raw_writel(val, base + reg);
 }
 
-static inline u32 ehci_read(void __iomem *base, u32 reg)
-{
-	return __raw_readl(base + reg);
-}
-
 /* configure so an HC device and id are always provided */
 /* always called with process context; sleeping is OK */