| Message ID | 20220512093210.GA6602@localhost.localdomain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers:Modify the return value to void | expand |
On Thu, May 12, 2022 at 05:32:10PM +0800, Zhou jie wrote: > drivers:Modify the return value to void > > Signed-off-by: Zhou jie <zhoujie@nfschina.com> > --- > drivers/usb/serial/mos7720.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c > index 1e12b5f30dcc..e944c32505da 100644 > --- a/drivers/usb/serial/mos7720.c > +++ b/drivers/usb/serial/mos7720.c > @@ -239,13 +239,12 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum, > > #ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT > > -static inline int mos7715_change_mode(struct mos7715_parport *mos_parport, > +static void mos7715_change_mode(struct mos7715_parport *mos_parport, > enum mos7715_pp_modes mode) > { > mos_parport->shadowECR = mode; > write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR, > mos_parport->shadowECR); > - return 0; > } > > static void destroy_mos_parport(struct kref *kref) > -- > 2.18.2 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On 12.05.22 11:32, Zhou jie wrote:
> drivers:Modify the return value to void
Hi,
technically the patch is obviously correct. Yet, it is not a good idea.
write_mos_reg() can fail and hiding errors is not a good strategy.
You'd better propagate the error.
Regards
Oliver
diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c index 1e12b5f30dcc..e944c32505da 100644 --- a/drivers/usb/serial/mos7720.c +++ b/drivers/usb/serial/mos7720.c @@ -239,13 +239,12 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum, #ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT -static inline int mos7715_change_mode(struct mos7715_parport *mos_parport, +static void mos7715_change_mode(struct mos7715_parport *mos_parport, enum mos7715_pp_modes mode) { mos_parport->shadowECR = mode; write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR, mos_parport->shadowECR); - return 0; } static void destroy_mos_parport(struct kref *kref)
drivers:Modify the return value to void Signed-off-by: Zhou jie <zhoujie@nfschina.com> --- drivers/usb/serial/mos7720.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)