| Message ID | 20220704070407.45618-2-lukasz.spintzyk@synaptics.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | DisplayLink USB-ethernet improvements | expand |
On Mon, Jul 04, 2022 at 09:04:06AM +0200, Łukasz Spintzyk wrote: > From: Dominik Czerwik <dominik.czerwik@synaptics.com> > > This improves performance and stability of > DL-3xxx/DL-5xxx/DL-6xxx device series. > > Signed-off-by: Dominik Czerwik <dominik.czerwik@synaptics.com> > Signed-off-by: Łukasz Spintzyk <lukasz.spintzyk@synaptics.com> > --- > drivers/net/usb/cdc_ncm.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index d55f59ce4a31..4594bf2982ee 100644 > --- a/drivers/net/usb/cdc_ncm.c > +++ b/drivers/net/usb/cdc_ncm.c > @@ -2,6 +2,7 @@ > * cdc_ncm.c > * > * Copyright (C) ST-Ericsson 2010-2012 > + * Copyright (C) 2022 Synaptics Incorporated. All rights reserved. As I ask many times for other copyright additions, when making a change like this, for such a tiny patch, I want to see a lawyer from your company also sign off on the patch proving that they agree that this line should be added. thanks, greg k-h
On 04/07/2022 09:25, Greg KH wrote: > CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe. > > > On Mon, Jul 04, 2022 at 09:04:06AM +0200, Łukasz Spintzyk wrote: >> From: Dominik Czerwik <dominik.czerwik@synaptics.com> >> >> This improves performance and stability of >> DL-3xxx/DL-5xxx/DL-6xxx device series. >> >> Signed-off-by: Dominik Czerwik <dominik.czerwik@synaptics.com> >> Signed-off-by: Łukasz Spintzyk <lukasz.spintzyk@synaptics.com> >> --- >> drivers/net/usb/cdc_ncm.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c >> index d55f59ce4a31..4594bf2982ee 100644 >> --- a/drivers/net/usb/cdc_ncm.c >> +++ b/drivers/net/usb/cdc_ncm.c >> @@ -2,6 +2,7 @@ >> * cdc_ncm.c >> * >> * Copyright (C) ST-Ericsson 2010-2012 >> + * Copyright (C) 2022 Synaptics Incorporated. All rights reserved. > > As I ask many times for other copyright additions, when making a change > like this, for such a tiny patch, I want to see a lawyer from your > company also sign off on the patch proving that they agree that this > line should be added. > > thanks, > > greg k-h Ok, I will contact company's layer and will be back with updated patches if needed. thanks Łukasz Spintzyk
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index d55f59ce4a31..4594bf2982ee 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -2,6 +2,7 @@ * cdc_ncm.c * * Copyright (C) ST-Ericsson 2010-2012 + * Copyright (C) 2022 Synaptics Incorporated. All rights reserved. * Contact: Alexey Orishko <alexey.orishko@stericsson.com> * Original author: Hans Petter Selasky <hans.petter.selasky@stericsson.com> * @@ -1904,6 +1905,19 @@ static const struct driver_info cdc_ncm_info = { .set_rx_mode = usbnet_cdc_update_filter, }; +/* Same as cdc_ncm_info, but with FLAG_SEND_ZLP */ +static const struct driver_info cdc_ncm_zlp_info = { + .description = "CDC NCM (SEND ZLP)", + .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET + | FLAG_LINK_INTR | FLAG_ETHER | FLAG_SEND_ZLP, + .bind = cdc_ncm_bind, + .unbind = cdc_ncm_unbind, + .manage_power = usbnet_manage_power, + .status = cdc_ncm_status, + .rx_fixup = cdc_ncm_rx_fixup, + .tx_fixup = cdc_ncm_tx_fixup, +}; + /* Same as cdc_ncm_info, but with FLAG_WWAN */ static const struct driver_info wwan_info = { .description = "Mobile Broadband Network Device", @@ -2010,6 +2024,16 @@ static const struct usb_device_id cdc_devs[] = { .driver_info = (unsigned long)&wwan_info, }, + /* DisplayLink docking stations */ + { .match_flags = USB_DEVICE_ID_MATCH_INT_INFO + | USB_DEVICE_ID_MATCH_VENDOR, + .idVendor = 0x17e9, + .bInterfaceClass = USB_CLASS_COMM, + .bInterfaceSubClass = USB_CDC_SUBCLASS_NCM, + .bInterfaceProtocol = USB_CDC_PROTO_NONE, + .driver_info = (unsigned long)&cdc_ncm_zlp_info, + }, + /* Generic CDC-NCM devices */ { USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),