| Message ID | 20220804110836.138614-1-tw.rayhung@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ad57410d231da1fff3f53ff42ebcdc6d388e21d1 |
| Headers | show |
| Series | usb: gadget: rndis: use %u instead of %d to print u32 values | expand |
On Thu, Aug 04, 2022 at 07:08:36PM +0800, Ray Hung wrote: > The driver uses the %d format to print u32 values. The correct > format is %u. Fix it. > > Signed-off-by: Ray Hung <tw.rayhung@gmail.com> > --- > drivers/usb/gadget/function/rndis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c > index 713efd9aefde..10ba339bcea4 100644 > --- a/drivers/usb/gadget/function/rndis.c > +++ b/drivers/usb/gadget/function/rndis.c > @@ -1105,7 +1105,7 @@ static int rndis_proc_show(struct seq_file *m, void *v) > "used : %s\n" > "state : %s\n" > "medium : 0x%08X\n" > - "speed : %d\n" > + "speed : %u\n" > "cable : %s\n" > "vendor ID : 0x%08X\n" > "vendor : %s\n", > -- > 2.25.1 > What commit id does this fix? And given this is only for debugging, there's no rush, right? thanks, greg k-h
Hi, What commit id does this fix? > It's 1da177e4c3f4 And given this is only for debugging, there's no rush, right? > Yes, only for debugging Thanks! Ray Greg KH <gregkh@linuxfoundation.org> 於 2022年8月4日 週四 晚上7:25寫道： > > On Thu, Aug 04, 2022 at 07:08:36PM +0800, Ray Hung wrote: > > The driver uses the %d format to print u32 values. The correct > > format is %u. Fix it. > > > > Signed-off-by: Ray Hung <tw.rayhung@gmail.com> > > --- > > drivers/usb/gadget/function/rndis.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c > > index 713efd9aefde..10ba339bcea4 100644 > > --- a/drivers/usb/gadget/function/rndis.c > > +++ b/drivers/usb/gadget/function/rndis.c > > @@ -1105,7 +1105,7 @@ static int rndis_proc_show(struct seq_file *m, void *v) > > "used : %s\n" > > "state : %s\n" > > "medium : 0x%08X\n" > > - "speed : %d\n" > > + "speed : %u\n" > > "cable : %s\n" > > "vendor ID : 0x%08X\n" > > "vendor : %s\n", > > -- > > 2.25.1 > > > > What commit id does this fix? > > And given this is only for debugging, there's no rush, right? > > thanks, > > greg k-h
diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c index 713efd9aefde..10ba339bcea4 100644 --- a/drivers/usb/gadget/function/rndis.c +++ b/drivers/usb/gadget/function/rndis.c @@ -1105,7 +1105,7 @@ static int rndis_proc_show(struct seq_file *m, void *v) "used : %s\n" "state : %s\n" "medium : 0x%08X\n" - "speed : %d\n" + "speed : %u\n" "cable : %s\n" "vendor ID : 0x%08X\n" "vendor : %s\n",
The driver uses the %d format to print u32 values. The correct format is %u. Fix it. Signed-off-by: Ray Hung <tw.rayhung@gmail.com> --- drivers/usb/gadget/function/rndis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)