| Message ID | 20220811070358.5472-1-zhoujie@nfschina.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb/serial:Modify the return value to void | expand |
On Thu, Aug 11, 2022 at 03:03:58PM +0800, Zhou jie wrote: > Modify the return value to void,The return value is not used elsewhere. > > Signed-off-by: Zhou jie <zhoujie@nfschina.com> > --- > drivers/usb/serial/mos7720.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c > index 1e12b5f30dcc..ddb3a2d0f819 100644 > --- a/drivers/usb/serial/mos7720.c > +++ b/drivers/usb/serial/mos7720.c > @@ -239,13 +239,12 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum, > > #ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT > > -static inline int mos7715_change_mode(struct mos7715_parport *mos_parport, > +static inline void mos7715_change_mode(struct mos7715_parport *mos_parport, > enum mos7715_pp_modes mode) > { > mos_parport->shadowECR = mode; > write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR, > mos_parport->shadowECR); > - return 0; Why not check the return value of write_mos_reg() and properly handle the error that can give you instead of ignoring it? thanks, greg k-h
v2: Modifying function return value type does not work
diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c index 1e12b5f30dcc..ddb3a2d0f819 100644 --- a/drivers/usb/serial/mos7720.c +++ b/drivers/usb/serial/mos7720.c @@ -239,13 +239,12 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum, #ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT -static inline int mos7715_change_mode(struct mos7715_parport *mos_parport, +static inline void mos7715_change_mode(struct mos7715_parport *mos_parport, enum mos7715_pp_modes mode) { mos_parport->shadowECR = mode; write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR, mos_parport->shadowECR); - return 0; } static void destroy_mos_parport(struct kref *kref)
Modify the return value to void,The return value is not used elsewhere. Signed-off-by: Zhou jie <zhoujie@nfschina.com> --- drivers/usb/serial/mos7720.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)