diff mbox series

[4/4] dt-bindings: mfd: syscon: require specific compatible also for simple-mfd

Message ID 20220817142246.828762-5-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Commit f5e90351a31f96e7e42a14a5cc686450b60fb94a
Headers show
Series mfd/phy/remoteproc: dt-bindings: syscon: be specific | expand

Commit Message

Krzysztof Kozlowski Aug. 17, 2022, 2:22 p.m. UTC
The syscon bindings require a device specific compatible, beside the
"syscon".  However schema counts "simple-mfd" as such, which allows
simple-mfd+syscon to sneak in.

Adjust the match to be sure simple-mfd also comes with a device specific
compatible.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comments

Lee Jones Sept. 5, 2022, 2:40 p.m. UTC | #1
On Wed, 17 Aug 2022, Krzysztof Kozlowski wrote:

> The syscon bindings require a device specific compatible, beside the
> "syscon".  However schema counts "simple-mfd" as such, which allows
> simple-mfd+syscon to sneak in.
> 
> Adjust the match to be sure simple-mfd also comes with a device specific
> compatible.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index c958086a5fc3..a64c7a71e6fe 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -72,7 +72,7 @@  properties:
       - contains:
           const: syscon
         minItems: 2
-        maxItems: 4  # Should be enough
+        maxItems: 5  # Should be enough
 
   reg:
     maxItems: 1
@@ -93,6 +93,18 @@  required:
   - compatible
   - reg
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: simple-mfd
+    then:
+      properties:
+        compatible:
+          minItems: 3
+          maxItems: 5
+
 additionalProperties: true
 
 examples: