diff mbox series

[3/6] media: remove reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER

Message ID 20220908104337.11940-4-lukas.bulwahn@gmail.com (mailing list archive)
State Accepted
Commit f7ec3f62d7736ed14050716943a9562879155fcc
Headers show
Series Remove CONFIG_EMBEDDED | expand

Commit Message

Lukas Bulwahn Sept. 8, 2022, 10:43 a.m. UTC
The config EMBEDDED selects EXPERT, i.e., when EMBEDDED is enabled, EXPERT
is usually also enabled. Hence, it sufficient to have the option
MEDIA_SUPPORT_FILTER set to y if !EXPERT.

This way, MEDIA_SUPPORT_FILTER does not refer to CONFIG_EMBEDDED anymore
and allows us to remove CONFIG_EMBEDDED in the close future.

Remove the reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 drivers/media/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mauro Carvalho Chehab Sept. 8, 2022, 11:13 a.m. UTC | #1
Em Thu,  8 Sep 2022 12:43:34 +0200
Lukas Bulwahn <lukas.bulwahn@gmail.com> escreveu:

> The config EMBEDDED selects EXPERT, i.e., when EMBEDDED is enabled, EXPERT
> is usually also enabled. Hence, it sufficient to have the option
> MEDIA_SUPPORT_FILTER set to y if !EXPERT.
> 
> This way, MEDIA_SUPPORT_FILTER does not refer to CONFIG_EMBEDDED anymore
> and allows us to remove CONFIG_EMBEDDED in the close future.
> 
> Remove the reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  drivers/media/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index ba6592b3dab2..283b78b5766e 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -24,7 +24,7 @@ if MEDIA_SUPPORT
>  
>  config MEDIA_SUPPORT_FILTER
>  	bool "Filter media drivers"
> -	default y if !EMBEDDED && !EXPERT
> +	default y if !EXPERT
>  	help
>  	   Configuring the media subsystem can be complex, as there are
>  	   hundreds of drivers and other config options.

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Thanks,
Mauro
Mauro Carvalho Chehab Sept. 8, 2022, 4:20 p.m. UTC | #2
Em Thu, 8 Sep 2022 13:13:03 +0200
Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:

> Em Thu,  8 Sep 2022 12:43:34 +0200
> Lukas Bulwahn <lukas.bulwahn@gmail.com> escreveu:
> 
> > The config EMBEDDED selects EXPERT, i.e., when EMBEDDED is enabled, EXPERT
> > is usually also enabled. Hence, it sufficient to have the option
> > MEDIA_SUPPORT_FILTER set to y if !EXPERT.
> > 
> > This way, MEDIA_SUPPORT_FILTER does not refer to CONFIG_EMBEDDED anymore
> > and allows us to remove CONFIG_EMBEDDED in the close future.
> > 
> > Remove the reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER.
> > 
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> >  drivers/media/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > index ba6592b3dab2..283b78b5766e 100644
> > --- a/drivers/media/Kconfig
> > +++ b/drivers/media/Kconfig
> > @@ -24,7 +24,7 @@ if MEDIA_SUPPORT
> >  
> >  config MEDIA_SUPPORT_FILTER
> >  	bool "Filter media drivers"
> > -	default y if !EMBEDDED && !EXPERT
> > +	default y if !EXPERT
> >  	help
> >  	   Configuring the media subsystem can be complex, as there are
> >  	   hundreds of drivers and other config options.  
> 
> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

As this is independent on the rest of the series, I just went ahead
and merged it on media tree.
> 
> Thanks,
> Mauro



Thanks,
Mauro
Masahiro Yamada Sept. 9, 2022, 6:22 a.m. UTC | #3
On Fri, Sep 9, 2022 at 1:20 AM Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
>
> Em Thu, 8 Sep 2022 13:13:03 +0200
> Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:
>
> > Em Thu,  8 Sep 2022 12:43:34 +0200
> > Lukas Bulwahn <lukas.bulwahn@gmail.com> escreveu:
> >
> > > The config EMBEDDED selects EXPERT, i.e., when EMBEDDED is enabled, EXPERT
> > > is usually also enabled. Hence, it sufficient to have the option
> > > MEDIA_SUPPORT_FILTER set to y if !EXPERT.
> > >
> > > This way, MEDIA_SUPPORT_FILTER does not refer to CONFIG_EMBEDDED anymore
> > > and allows us to remove CONFIG_EMBEDDED in the close future.
> > >
> > > Remove the reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER.
> > >
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > >  drivers/media/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > > index ba6592b3dab2..283b78b5766e 100644
> > > --- a/drivers/media/Kconfig
> > > +++ b/drivers/media/Kconfig
> > > @@ -24,7 +24,7 @@ if MEDIA_SUPPORT
> > >
> > >  config MEDIA_SUPPORT_FILTER
> > >     bool "Filter media drivers"
> > > -   default y if !EMBEDDED && !EXPERT
> > > +   default y if !EXPERT
> > >     help
> > >        Configuring the media subsystem can be complex, as there are
> > >        hundreds of drivers and other config options.
> >
> > Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> As this is independent on the rest of the series, I just went ahead
> and merged it on media tree.
> >
> > Thanks,
> > Mauro
>
>
>
> Thanks,
> Mauro

Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
diff mbox series

Patch

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index ba6592b3dab2..283b78b5766e 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -24,7 +24,7 @@  if MEDIA_SUPPORT
 
 config MEDIA_SUPPORT_FILTER
 	bool "Filter media drivers"
-	default y if !EMBEDDED && !EXPERT
+	default y if !EXPERT
 	help
 	   Configuring the media subsystem can be complex, as there are
 	   hundreds of drivers and other config options.