diff mbox series

[v2,2/2] usb: xhci-pci: Set PROBE_PREFER_ASYNCHRONOUS

Message ID 20221028184507.v2.2.I5a309231785d3a4e37118a25e84f5caa0136a343@changeid (mailing list archive)
State Accepted
Commit 4c2604a9a6899bab195edbee35fc8d64ce1444aa
Headers show
Series [v2,1/2] usb: ehci-pci: Set PROBE_PREFER_ASYNCHRONOUS | expand

Commit Message

Brian Norris Oct. 29, 2022, 1:45 a.m. UTC
This driver often takes on the order of 10ms to start, but in some cases
takes more than 100ms. It shouldn't have many cross-device dependencies
to race with, nor racy access to shared state with other drivers, so
this should be a relatively low risk change.

This driver was pinpointed as part of a survey of top slowest initcalls
(i.e., are built in, and probing synchronously) on a lab of ChromeOS
systems.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---

Changes in v2:
 - Move outside #ifdef CONFIG_PM (oops; thanks Alan)

 drivers/usb/host/xhci-pci.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 40228a3d77a0..5bbb1fed32d2 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -687,11 +687,12 @@  static struct pci_driver xhci_pci_driver = {
 	/* suspend and resume implemented later */
 
 	.shutdown = 	usb_hcd_pci_shutdown,
-#ifdef CONFIG_PM
 	.driver = {
-		.pm = &usb_hcd_pci_pm_ops
-	},
+#ifdef CONFIG_PM
+		.pm = &usb_hcd_pci_pm_ops,
 #endif
+		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
+	},
 };
 
 static int __init xhci_pci_init(void)