| Message ID | 20221114124053.1873316-10-waynec@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable USB host and device functions on Jetson | expand |
On 14/11/2022 12:40, Wayne Chang wrote: > Remove the property ccgx,firmware-build as we have added well-known > regex cypress,firmware-build. > > Signed-off-by: Wayne Chang <waynec@nvidia.com> > --- > V2 -> V3:nothing has changed > V1 -> V2:New added for bisectablility > drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c > index 9b2e13bd44db..092d4d52098c 100644 > --- a/drivers/i2c/busses/i2c-nvidia-gpu.c > +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c > @@ -259,8 +259,7 @@ static const struct pci_device_id gpu_i2c_ids[] = { > MODULE_DEVICE_TABLE(pci, gpu_i2c_ids); > > static const struct property_entry ccgx_props[] = { > - /* Use FW built for NVIDIA (nv) only */ > - PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'), > + /* Use FW built for NVIDIA GPU only */ > PROPERTY_ENTRY_STRING("cypress,firmware-build", "nvidia,gpu"), > { } > }; Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Thanks Jon
On Mon, Nov 14, 2022 at 08:40:49PM +0800, Wayne Chang wrote: > Remove the property ccgx,firmware-build as we have added well-known > regex cypress,firmware-build. > > Signed-off-by: Wayne Chang <waynec@nvidia.com> Acked-by: Wolfram Sang <wsa@kernel.org>
diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c index 9b2e13bd44db..092d4d52098c 100644 --- a/drivers/i2c/busses/i2c-nvidia-gpu.c +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c @@ -259,8 +259,7 @@ static const struct pci_device_id gpu_i2c_ids[] = { MODULE_DEVICE_TABLE(pci, gpu_i2c_ids); static const struct property_entry ccgx_props[] = { - /* Use FW built for NVIDIA (nv) only */ - PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'), + /* Use FW built for NVIDIA GPU only */ PROPERTY_ENTRY_STRING("cypress,firmware-build", "nvidia,gpu"), { } };
Remove the property ccgx,firmware-build as we have added well-known regex cypress,firmware-build. Signed-off-by: Wayne Chang <waynec@nvidia.com> --- V2 -> V3:nothing has changed V1 -> V2:New added for bisectablility drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)