diff mbox series

MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER

Message ID 20221115103153.28502-1-lukas.bulwahn@gmail.com (mailing list archive)
State Accepted
Commit 488c2c67463cc704715e9d4b68c9edfcc20f299d
Headers show
Series MAINTAINERS: rectify entry for MICROCHIP USB251XB DRIVER | expand

Commit Message

Lukas Bulwahn Nov. 15, 2022, 10:31 a.m. UTC
Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
in MAINTAINERS.

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
broken reference.

Repair this file reference in MICROCHIP USB251XB DRIVER.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Marek, please ack.

Greg, please pick this minor non-urgent patch on top of the commit above.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Nov. 15, 2022, 10:35 a.m. UTC | #1
On 15/11/2022 11:31, Lukas Bulwahn wrote:
> Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
> in MAINTAINERS.
> 
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
> 
> Repair this file reference in MICROCHIP USB251XB DRIVER.
> 
You know this could be just one sentence (instead of three paragraphs)
with a Fixes tag...

Best regards,
Krzysztof
Marek Vasut Nov. 15, 2022, 10:52 a.m. UTC | #2
On 11/15/22 11:35, Krzysztof Kozlowski wrote:
> On 15/11/2022 11:31, Lukas Bulwahn wrote:
>> Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
>> converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
>> in MAINTAINERS.
>>
>> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
>> broken reference.
>>
>> Repair this file reference in MICROCHIP USB251XB DRIVER.
>>
> You know this could be just one sentence (instead of three paragraphs)
> with a Fixes tag...

On the other hand, the content is educational, e.g. about the usage of 
get_maintainer.pl script .

Acked-by: Marek Vasut <marex@denx.de>
Krzysztof Kozlowski Nov. 15, 2022, 10:54 a.m. UTC | #3
On 15/11/2022 11:52, Marek Vasut wrote:
> On 11/15/22 11:35, Krzysztof Kozlowski wrote:
>> On 15/11/2022 11:31, Lukas Bulwahn wrote:
>>> Commit fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
>>> converts usb251xb.txt to usb251xb.yaml, but misses to adjust its reference
>>> in MAINTAINERS.
>>>
>>> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
>>> broken reference.
>>>
>>> Repair this file reference in MICROCHIP USB251XB DRIVER.
>>>
>> You know this could be just one sentence (instead of three paragraphs)
>> with a Fixes tag...
> 
> On the other hand, the content is educational, e.g. about the usage of 
> get_maintainer.pl script .

Education is good, but I don't see a point to grow commit log with this.
The warning would be useful, but the command? Just store it in
Documentation if the intention is to educate.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index fdcf1e020a5a..43f9e2abe893 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13726,7 +13726,7 @@  MICROCHIP USB251XB DRIVER
 M:	Richard Leitner <richard.leitner@skidata.com>
 L:	linux-usb@vger.kernel.org
 S:	Maintained
-F:	Documentation/devicetree/bindings/usb/usb251xb.txt
+F:	Documentation/devicetree/bindings/usb/usb251xb.yaml
 F:	drivers/usb/misc/usb251xb.c
 
 MICROCHIP USBA UDC DRIVER