| Message ID | 20221130154111.1655603-1-thierry.reding@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d8a76e46d7d3d6db5458d7f46205153ca9a53afd |
| Headers | show |
| Series | dt-bindings: usb: tegra-xusb: Remove path references | expand |
On 30/11/2022 16:41, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Unresolved path references are now flagged as errors when checking the > device tree binding examples, so convert them into label references. > > Reported-by: Conor Dooley <conor.dooley@microchip.com> > Suggested-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, Nov 30, 2022 at 4:52 PM Thierry Reding <thierry.reding@gmail.com> wrote: > From: Thierry Reding <treding@nvidia.com> > > Unresolved path references are now flagged as errors when checking the > device tree binding examples, so convert them into label references. > > Reported-by: Conor Dooley <conor.dooley@microchip.com> > Suggested-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Thierry Reding <treding@nvidia.com> This fixes "make dt_binding_check" for me, so Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, Nov 30, 2022 at 04:41:11PM +0100, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Unresolved path references are now flagged as errors when checking the > device tree binding examples, so convert them into label references. > > Reported-by: Conor Dooley <conor.dooley@microchip.com> > Suggested-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml | 4 +--- > .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml | 4 +--- > .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml | 8 ++------ > .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml | 8 ++------ > 4 files changed, 6 insertions(+), 18 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
On Wed, Nov 30, 2022 at 04:41:11PM +0100, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Unresolved path references are now flagged as errors when checking the > device tree binding examples, so convert them into label references. > > Reported-by: Conor Dooley <conor.dooley@microchip.com> > Suggested-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml | 4 +--- > .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml | 4 +--- > .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml | 8 ++------ > .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml | 8 ++------ > 4 files changed, 6 insertions(+), 18 deletions(-) As this is the only binding issue remaining in Linus's tree and it's the only thing in the Tegra tree, I've applied it for rc1. Rob
On Fri, Dec 16, 2022 at 11:40:34AM -0600, Rob Herring wrote: > On Wed, Nov 30, 2022 at 04:41:11PM +0100, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > Unresolved path references are now flagged as errors when checking the > > device tree binding examples, so convert them into label references. > > > > Reported-by: Conor Dooley <conor.dooley@microchip.com> > > Suggested-by: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml | 4 +--- > > .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml | 4 +--- > > .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml | 8 ++------ > > .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml | 8 ++------ > > 4 files changed, 6 insertions(+), 18 deletions(-) > > As this is the only binding issue remaining in Linus's tree and it's the > only thing in the Tegra tree, I've applied it for rc1. I was waiting for more fixes to come in before sending out another PR, but nothing else showed up, so taking this through your tree makes more sense. Thanks, Thierry
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml index 4a6616bf9bab..d6ca8c93073d 100644 --- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml @@ -186,9 +186,7 @@ examples: nvidia,xusb-padctl = <&padctl>; - phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */ - <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */ - <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */ + phys = <&phy_usb2_1>, <&phy_usb2_2>, <&phy_pcie_0>; phy-names = "usb2-1", "usb2-2", "usb3-0"; avddio-pex-supply = <&vdd_1v05_run>; diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml index 6f62944fc597..a04c6ce1e0f6 100644 --- a/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml @@ -166,8 +166,6 @@ examples: #address-cells = <1>; #size-cells = <0>; - phys = <&{/padctl@3520000/pads/usb2/lanes/usb2-0}>, - <&{/padctl@3520000/pads/usb2/lanes/usb2-1}>, - <&{/padctl@3520000/pads/usb3/lanes/usb3-0}>; + phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb3_0>; phy-names = "usb2-0", "usb2-1", "usb3-0"; }; diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml index 65ae9ae9b0b7..b356793f73a1 100644 --- a/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml @@ -169,11 +169,7 @@ examples: nvidia,xusb-padctl = <&xusb_padctl>; - phys = <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-0}>, - <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-1}>, - <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-3}>, - <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-0}>, - <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-2}>, - <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-3}>; + phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb2_3>, <&phy_usb3_0>, + <&phy_usb3_2>, <&phy_usb3_3>; phy-names = "usb2-0", "usb2-1", "usb2-3", "usb3-0", "usb3-2", "usb3-3"; }; diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml index da1e1ec0e7c8..90296613b3a5 100644 --- a/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml @@ -173,12 +173,8 @@ examples: nvidia,xusb-padctl = <&padctl>; - phys = <&{/padctl@7009f000/pads/usb2/lanes/usb2-0}>, - <&{/padctl@7009f000/pads/usb2/lanes/usb2-1}>, - <&{/padctl@7009f000/pads/usb2/lanes/usb2-2}>, - <&{/padctl@7009f000/pads/usb2/lanes/usb2-3}>, - <&{/padctl@7009f000/pads/pcie/lanes/pcie-6}>, - <&{/padctl@7009f000/pads/pcie/lanes/pcie-5}>; + phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb2_2>, <&phy_usb2_3>, + <&phy_pcie_6>, <&phy_pcie_5>; phy-names = "usb2-0", "usb2-1", "usb2-2", "usb2-3", "usb3-0", "usb3-1"; dvddio-pex-supply = <&vdd_pex_1v05>;