diff mbox series

usb: gadget: u_ether: remove obnoxious warning messages

Message ID 20221209172853.2138941-1-alvin@pqrs.dk (mailing list archive)
State Accepted
Commit 19ac99072e679f1e3807603206e3f3b1a7c14729
Headers show
Series usb: gadget: u_ether: remove obnoxious warning messages | expand

Commit Message

Alvin Šipraga Dec. 9, 2022, 5:28 p.m. UTC 
From: Alvin Šipraga <alsi@bang-olufsen.dk>

There is really no need for the driver to unconditionally emit warnings
like this on every usage:

[    6.967283] using random self ethernet address
[    6.967294] using random host ethernet address

Since this is normal behaviour, just remove the messages altogether.

Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
---
 drivers/usb/gadget/function/u_ether.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andrzej Pietrasiewicz Dec. 12, 2022, 8:07 a.m. UTC | #1 
W dniu 9.12.2022 o 18:28, Alvin Šipraga pisze:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
> 
> There is really no need for the driver to unconditionally emit warnings
> like this on every usage:
> 
> [    6.967283] using random self ethernet address
> [    6.967294] using random host ethernet address
> 
> Since this is normal behaviour, just remove the messages altogether.
> > Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

> ---
>   drivers/usb/gadget/function/u_ether.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
> index 8f12f3f8f6ee..3fdc913ef262 100644
> --- a/drivers/usb/gadget/function/u_ether.c
> +++ b/drivers/usb/gadget/function/u_ether.c
> @@ -845,13 +845,11 @@ struct net_device *gether_setup_name_default(const char *netname)
>   	snprintf(net->name, sizeof(net->name), "%s%%d", netname);
>   
>   	eth_random_addr(dev->dev_mac);
> -	pr_warn("using random %s ethernet address\n", "self");
>   
>   	/* by default we always have a random MAC address */
>   	net->addr_assign_type = NET_ADDR_RANDOM;
>   
>   	eth_random_addr(dev->host_mac);
> -	pr_warn("using random %s ethernet address\n", "host");
>   
>   	net->netdev_ops = &eth_netdev_ops;
>
Greg KH Jan. 17, 2023, 3:04 p.m. UTC | #2 
On Fri, Dec 09, 2022 at 06:28:53PM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
> 
> There is really no need for the driver to unconditionally emit warnings
> like this on every usage:
> 
> [    6.967283] using random self ethernet address
> [    6.967294] using random host ethernet address
> 
> Since this is normal behaviour, just remove the messages altogether.
> 
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> ---
>  drivers/usb/gadget/function/u_ether.c | 2 --
>  1 file changed, 2 deletions(-)

Please see the thread at:
	https://lore.kernel.org/r/20230116155545.101391-1-jonathanh@nvidia.com

for more details.

This should use dev_warn() or better yet, just dev_dbg().

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 8f12f3f8f6ee..3fdc913ef262 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -845,13 +845,11 @@  struct net_device *gether_setup_name_default(const char *netname)
 	snprintf(net->name, sizeof(net->name), "%s%%d", netname);
 
 	eth_random_addr(dev->dev_mac);
-	pr_warn("using random %s ethernet address\n", "self");
 
 	/* by default we always have a random MAC address */
 	net->addr_assign_type = NET_ADDR_RANDOM;
 
 	eth_random_addr(dev->host_mac);
-	pr_warn("using random %s ethernet address\n", "host");
 
 	net->netdev_ops = &eth_netdev_ops;