| Message ID | 20221219191855.2010466-2-allenwebb@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Generate modules.builtin.alias from match ids | expand |
On Mon, Dec 19, 2022 at 01:18:47PM -0600, Allen Webb wrote: > A one character difference in the name supplied to MODULE_DEVICE_TABLE > breaks a future patch set, so fix the typo. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Allen Webb <allenwebb@google.com> > --- > drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > index 0e3b6ba22f943..344a0a71df14a 100644 > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > @@ -743,7 +743,7 @@ static const struct of_device_id imx8mp_blk_ctrl_of_match[] = { > /* Sentinel */ > } > }; > -MODULE_DEVICE_TABLE(of, imx8m_blk_ctrl_of_match); > +MODULE_DEVICE_TABLE(of, imx8mp_blk_ctrl_of_match); What commit id does this fix? Shouldn't this be also cc: stable to resolve this issue for older kernels as obviousl the module device table for auto-loading is not correct? thanks, greg k-h
On Mon, Dec 19, 2022 at 1:22 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Dec 19, 2022 at 01:18:47PM -0600, Allen Webb wrote: > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > breaks a future patch set, so fix the typo. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Allen Webb <allenwebb@google.com> > > --- > > drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > > index 0e3b6ba22f943..344a0a71df14a 100644 > > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > > @@ -743,7 +743,7 @@ static const struct of_device_id imx8mp_blk_ctrl_of_match[] = { > > /* Sentinel */ > > } > > }; > > -MODULE_DEVICE_TABLE(of, imx8m_blk_ctrl_of_match); > > +MODULE_DEVICE_TABLE(of, imx8mp_blk_ctrl_of_match); > > What commit id does this fix? Shouldn't this be also cc: stable to > resolve this issue for older kernels as obviousl the module device table > for auto-loading is not correct? I have included Cc stable and Fixes: for the three patches that were obvious typos and will upload a follow-up series shortly. It is unlikely these drivers were being built as modules because the build would have been broken for that configuration. This seems to be the most recent case so it is the most likely to make a difference, but I would imagine SOC drivers might not be loadable in practice if they are needed to bootstrap the system to a point that loadable modules can be accessed. > > thanks, > > greg k-h
diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c index 0e3b6ba22f943..344a0a71df14a 100644 --- a/drivers/soc/imx/imx8mp-blk-ctrl.c +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c @@ -743,7 +743,7 @@ static const struct of_device_id imx8mp_blk_ctrl_of_match[] = { /* Sentinel */ } }; -MODULE_DEVICE_TABLE(of, imx8m_blk_ctrl_of_match); +MODULE_DEVICE_TABLE(of, imx8mp_blk_ctrl_of_match); static struct platform_driver imx8mp_blk_ctrl_driver = { .probe = imx8mp_blk_ctrl_probe,
A one character difference in the name supplied to MODULE_DEVICE_TABLE breaks a future patch set, so fix the typo. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Allen Webb <allenwebb@google.com> --- drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)