| Message ID | 20221219204619.2205248-2-allenwebb@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d77369ad8cb10bedd244e6dfd8414ebdd8594ba6 |
| Headers | show |
| Series | Generate modules.builtin.alias from match ids | expand |
On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote: > A one character difference in the name supplied to MODULE_DEVICE_TABLE > breaks a future patch set, so fix the typo. What behaviour is broken here for older kernels? What would not work that makes this patch worthy of consideration for stable? The commit log should be clear on that. In the future, it may be useful for you to wait at least 1 week or so before sending a new series becuase just a couple of days is not enough if you are getting feedback. So before sending a v10, please give it at least a few days or a week. Luis
On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote: > A one character difference in the name supplied to MODULE_DEVICE_TABLE > breaks a future patch set, so fix the typo. Breaking a future change is not worth a stable backport, right? Doesn't this fix a real issue now? If so, please explain that. thanks, greg k-h
On Mon, Dec 19, 2022 at 3:23 PM Luis Chamberlain <mcgrof@kernel.org> wrote: > > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote: > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > breaks a future patch set, so fix the typo. > > What behaviour is broken here for older kernels? What would not work > that makes this patch worthy of consideration for stable? The commit > log should be clear on that. > > In the future, it may be useful for you to wait at least 1 week or so > before sending a new series becuase just a couple of days is not enough > if you are getting feedback. > > So before sending a v10, please give it at least a few days or a week. > > Luis On Tue, Dec 20, 2022 at 12:42 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote: > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > breaks a future patch set, so fix the typo. > > Breaking a future change is not worth a stable backport, right? Doesn't > this fix a real issue now? If so, please explain that. > > thanks, > > greg k-h I will update the commit message to say that it breaks compilation when building imx8mp-blk-ctrl as a module (and so forth for the other similar patches).
On Tue, Dec 20, 2022 at 08:26:06AM -0600, Allen Webb wrote: > On Mon, Dec 19, 2022 at 3:23 PM Luis Chamberlain <mcgrof@kernel.org> wrote: > > > > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote: > > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > > breaks a future patch set, so fix the typo. > > > > What behaviour is broken here for older kernels? What would not work > > that makes this patch worthy of consideration for stable? The commit > > log should be clear on that. > > > > In the future, it may be useful for you to wait at least 1 week or so > > before sending a new series becuase just a couple of days is not enough > > if you are getting feedback. > > > > So before sending a v10, please give it at least a few days or a week. > > > > Luis > > On Tue, Dec 20, 2022 at 12:42 AM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote: > > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > > breaks a future patch set, so fix the typo. > > > > Breaking a future change is not worth a stable backport, right? Doesn't > > this fix a real issue now? If so, please explain that. > > > > thanks, > > > > greg k-h > > I will update the commit message to say that it breaks compilation > when building imx8mp-blk-ctrl as a module (and so forth for the other > similar patches). Can that code be built as a module? Same for the other changes...
On Tue, Dec 20, 2022 at 8:32 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Tue, Dec 20, 2022 at 08:26:06AM -0600, Allen Webb wrote: > > On Mon, Dec 19, 2022 at 3:23 PM Luis Chamberlain <mcgrof@kernel.org> wrote: > > > > > > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote: > > > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > > > breaks a future patch set, so fix the typo. > > > > > > What behaviour is broken here for older kernels? What would not work > > > that makes this patch worthy of consideration for stable? The commit > > > log should be clear on that. > > > > > > In the future, it may be useful for you to wait at least 1 week or so > > > before sending a new series becuase just a couple of days is not enough > > > if you are getting feedback. > > > > > > So before sending a v10, please give it at least a few days or a week. > > > > > > Luis > > > > On Tue, Dec 20, 2022 at 12:42 AM Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> wrote: > > > > > > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote: > > > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > > > breaks a future patch set, so fix the typo. > > > > > > Breaking a future change is not worth a stable backport, right? Doesn't > > > this fix a real issue now? If so, please explain that. > > > > > > thanks, > > > > > > greg k-h > > > > I will update the commit message to say that it breaks compilation > > when building imx8mp-blk-ctrl as a module (and so forth for the other > > similar patches). > > Can that code be built as a module? Same for the other changes... Nope, I will remove the cc: stable and revert the commit messages back to just referencing the future change, but this time I will be more specific. SOC_IMX8M symbol value 'm' invalid for SOC_IMX8M ROCKCHIP_MBOX symbol value 'm' invalid for ROCKCHIP_MBOX STMPE_SPI symbol value 'm' invalid for STMPE_SPI
diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c index 0e3b6ba22f94..344a0a71df14 100644 --- a/drivers/soc/imx/imx8mp-blk-ctrl.c +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c @@ -743,7 +743,7 @@ static const struct of_device_id imx8mp_blk_ctrl_of_match[] = { /* Sentinel */ } }; -MODULE_DEVICE_TABLE(of, imx8m_blk_ctrl_of_match); +MODULE_DEVICE_TABLE(of, imx8mp_blk_ctrl_of_match); static struct platform_driver imx8mp_blk_ctrl_driver = { .probe = imx8mp_blk_ctrl_probe,
A one character difference in the name supplied to MODULE_DEVICE_TABLE breaks a future patch set, so fix the typo. Cc: stable@vger.kernel.org Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Allen Webb <allenwebb@google.com> --- drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)