| Message ID | 20221220223006.3145568-1-utkarsh.h.patel@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | thunderbolt: Do not report errors if on-board retimers are found | expand |
On Tue, Dec 20, 2022 at 02:30:06PM -0800, Utkarsh Patel wrote: > tb_retimer_scan() returns error even when on-board retimers are found. > > Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned") > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> Please do not put a blank line between the "Fixes" tag and your signed-off-by. And is this also needed in stable kernels? If so, add the proper tag please. thanks, greg k-h
Hi Greg, Thank you for the review and feedback. > -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Tuesday, December 20, 2022 10:50 PM > To: Patel, Utkarsh H <utkarsh.h.patel@intel.com> > Cc: mika.westerberg@linux.intel.com; linux-kernel@vger.kernel.org; linux- > usb@vger.kernel.org; Mani, Rajmohan <rajmohan.mani@intel.com> > Subject: Re: [PATCH] thunderbolt: Do not report errors if on-board retimers > are found > > On Tue, Dec 20, 2022 at 02:30:06PM -0800, Utkarsh Patel wrote: > > tb_retimer_scan() returns error even when on-board retimers are found. > > > > Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when > > retimers are scanned") > > > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> > > Please do not put a blank line between the "Fixes" tag and your signed-off- > by. Ack. I will correct it in v2. > > And is this also needed in stable kernels? If so, add the proper tag please. Ack. Sincerely, Utkarsh Patel.
diff --git a/drivers/thunderbolt/retimer.c b/drivers/thunderbolt/retimer.c index 81252e31014a..6ebe7a2886ec 100644 --- a/drivers/thunderbolt/retimer.c +++ b/drivers/thunderbolt/retimer.c @@ -471,10 +471,9 @@ int tb_retimer_scan(struct tb_port *port, bool add) break; } - if (!last_idx) { - ret = 0; + ret = 0; + if (!last_idx) goto out; - } /* Add on-board retimers if they do not exist already */ for (i = 1; i <= last_idx; i++) {
tb_retimer_scan() returns error even when on-board retimers are found. Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned") Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> --- drivers/thunderbolt/retimer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)