| Message ID | 20230103-gemini-fotg210-usb-v1-1-f2670cb4a492@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: fotg210: Various improvements | expand |
On 04/01/2023 00:35, Linus Walleij wrote: > It turns out that this IP block exists in at least two > incarnations: FOTG200 and FOTG210. The one in the Gemini > is FOTG200, so add the variants and rectify the binding > for Gemini. > > This affects things such as the placement of certain > registers. > > It remains to be seen how similar this block is to the > third USB block from Faraday, FUSB220. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > Documentation/devicetree/bindings/usb/faraday,fotg210.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/faraday,fotg210.yaml b/Documentation/devicetree/bindings/usb/faraday,fotg210.yaml > index 84b3b69256b1..12d4fc742f20 100644 > --- a/Documentation/devicetree/bindings/usb/faraday,fotg210.yaml > +++ b/Documentation/devicetree/bindings/usb/faraday,fotg210.yaml > @@ -5,7 +5,7 @@ > $id: http://devicetree.org/schemas/usb/faraday,fotg210.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Faraday Technology FOTG210 HS OTG USB 2.0 controller > +title: Faraday Technology FOTG200 series HS OTG USB 2.0 controller Bindings That's not correct change, probably due to rebasing. Change the name only, do not add "Bindings". Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/faraday,fotg210.yaml b/Documentation/devicetree/bindings/usb/faraday,fotg210.yaml index 84b3b69256b1..12d4fc742f20 100644 --- a/Documentation/devicetree/bindings/usb/faraday,fotg210.yaml +++ b/Documentation/devicetree/bindings/usb/faraday,fotg210.yaml @@ -5,7 +5,7 @@ $id: http://devicetree.org/schemas/usb/faraday,fotg210.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Faraday Technology FOTG210 HS OTG USB 2.0 controller +title: Faraday Technology FOTG200 series HS OTG USB 2.0 controller Bindings maintainers: - Linus Walleij <linus.walleij@linaro.org> @@ -17,10 +17,11 @@ allOf: properties: compatible: oneOf: + - const: faraday,fotg200 - const: faraday,fotg210 - items: - const: cortina,gemini-usb - - const: faraday,fotg210 + - const: faraday,fotg200 reg: maxItems: 1 @@ -66,7 +67,7 @@ examples: #include <dt-bindings/clock/cortina,gemini-clock.h> #include <dt-bindings/reset/cortina,gemini-reset.h> usb0: usb@68000000 { - compatible = "cortina,gemini-usb", "faraday,fotg210"; + compatible = "cortina,gemini-usb", "faraday,fotg200"; reg = <0x68000000 0x1000>; interrupts = <10 IRQ_TYPE_LEVEL_HIGH>; resets = <&syscon GEMINI_RESET_USB0>;
It turns out that this IP block exists in at least two incarnations: FOTG200 and FOTG210. The one in the Gemini is FOTG200, so add the variants and rectify the binding for Gemini. This affects things such as the placement of certain registers. It remains to be seen how similar this block is to the third USB block from Faraday, FUSB220. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- Documentation/devicetree/bindings/usb/faraday,fotg210.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)