From patchwork Fri Jan 27 21:17:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13119421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 485DAC38142 for ; Fri, 27 Jan 2023 21:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231564AbjA0VR6 (ORCPT ); Fri, 27 Jan 2023 16:17:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbjA0VR4 (ORCPT ); Fri, 27 Jan 2023 16:17:56 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 518721CF67 for ; Fri, 27 Jan 2023 13:17:55 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id fl24so4326020wmb.1 for ; Fri, 27 Jan 2023 13:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=n2CqnTIkfAqED0CQ9aF9DG/sLx9ru/fz+pepxlbDILA=; b=NAX3/vBvZG6/s8AhSoJJmBMZWopusb2B7NRWdsTPrKQ+zYNDn+iIqAtAjx/ZNF2UI/ z3gLvKp2c/AkrCr5LrzvdCUQqU8hbaW1501X9Y5CRgLlGbk0n/dnrxae/9qnBXbztRtO MDRSHFhM8UmFzozoJ9YVeODEQKnJaRB9tonDpCWa5OhWZNR+6TCfQwTs5EvPhiw3QUTW qPVZkPSlOl+0SHZCry8Dn8kiqHb6jkZ/TbgCWlRuLeHxgVISHhq2Bhv90LCpYx1vQ2aU lVM3dNPaKFw4pe8RpZaHUJ+4Rb0KfRlEdNqA89r8pEMAmM41fbS2bbduXT8EGKkWKbuA znlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n2CqnTIkfAqED0CQ9aF9DG/sLx9ru/fz+pepxlbDILA=; b=WEU0qcaLRIHtpo9xWmQahmGnmPVIKvGxe7jGaNEL7D5JphIO216BEv5vG1Re5jdyr+ UM8WvR6Yho2v10/HG7kNdGUzqQDxrwiCbmE3EFrnFVZRfKWR+ATh0GP34/6DN/riGPfF ZXF+202Rk0ZmSugU64ul1sfzMiKYQe2bC1k+3w5pIuvBZr36qQYviH1tYrV65aLJJFSE G4XNL17XEYOlS+ug9d/LWnOmpg+jbLVXUHpp9lJeJtU35PmX1ZgJH35cGlGGxkcThbMl 1uRgnjxiEUkFg2lT1tXxwai8QWf+5rdKFV0+IdLlxc1bn84Y8v8bw0mE4z75QAliMukx PvpA== X-Gm-Message-State: AFqh2kq12JFzNHrQNey/RRdjBG2O49VY+n4mf8l/Nk2NzQ41DshclX4+ 4O+rWSa3g2uZRvBeyHOW2cHTSQ== X-Google-Smtp-Source: AMrXdXuAvXQR2Q0dQ5687sSwAmQYI3bktYVsYW/LUdQo+8U8qvC1x44cvRqs3S+hq8k5B0Me4mmBVQ== X-Received: by 2002:a1c:7712:0:b0:3da:1e35:dfec with SMTP id t18-20020a1c7712000000b003da1e35dfecmr41853351wmi.4.1674854273942; Fri, 27 Jan 2023 13:17:53 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id b5-20020a05600c150500b003dafb0c8dfbsm6080811wmg.14.2023.01.27.13.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 13:17:53 -0800 (PST) From: Krzysztof Kozlowski To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Martin_J=C3=BCcker?= , Henrik Grimler , Sam Protsenko , Chanho Park , Marek Szyprowski , Chanwoo Choi , Krzysztof Kozlowski Subject: [PATCH v2] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS Date: Fri, 27 Jan 2023 22:17:48 +0100 Message-Id: <20230127211748.260718-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The Samsung Exynos SoC USB 3.0 DWC3 Controller is a simple wrapper of actual DWC3 Controller device node. It handles necessary Samsung Exynos-specific resources (regulators, clocks), but does not have its own MMIO address space. However neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node which do not have unit address. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Rob Herring --- Changes since v1: 1. Use ranges with values and drop reg from usb-wrapper node. 2. Keep "usb" as wrapper's node name. DTS fixes are here: https://lore.kernel.org/linux-samsung-soc/20230127211527.260060-1-krzysztof.kozlowski@linaro.org/T/#t --- .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml index 6b9a3bcb3926..42ceaf13cd5d 100644 --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml @@ -108,19 +108,19 @@ examples: #include #include - usb { + usb@12000000 { compatible = "samsung,exynos5250-dwusb3"; #address-cells = <1>; #size-cells = <1>; - ranges; + ranges = <0x0 0x12000000 0x10000>; clocks = <&clock CLK_USBD300>; clock-names = "usbdrd30"; vdd33-supply = <&ldo9_reg>; vdd10-supply = <&ldo11_reg>; - usb@12000000 { + usb@0 { compatible = "snps,dwc3"; - reg = <0x12000000 0x10000>; + reg = <0x0 0x10000>; interrupts = ; phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>; phy-names = "usb2-phy", "usb3-phy";