From patchwork Mon Jan 30 13:03:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13121068 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D94C54EED for ; Mon, 30 Jan 2023 13:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236448AbjA3NEi (ORCPT ); Mon, 30 Jan 2023 08:04:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230374AbjA3NEh (ORCPT ); Mon, 30 Jan 2023 08:04:37 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5537C1724; Mon, 30 Jan 2023 05:04:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5A91BCE13AA; Mon, 30 Jan 2023 13:04:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77EFDC433D2; Mon, 30 Jan 2023 13:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675083872; bh=5mD/bBnB3Pzdve9B8z6/18LEwPDu/XSyvFNljbftvFs=; h=From:To:Cc:Subject:Date:From; b=JhtvhfdT4RoDqW2uaa6eMUqgqIQfikTNGfHGSRs8XBkPOyso+srzHhn/bmOZXC4J8 vkCfDP3kJp4eslTbO+d3tFVWSucJsSFSj304GJcxS+oMolg5SQumTcHCbN5bbwwTG0 TqBbYYtcs/0Dh+T2BeNrexrsN+GNmwRnGrsjuFYqi/TAeb96ZtLSF07H+NqGBHkcnV f9FvZ7b7ustilJNk/afB/ly9BF4d29m7H5zBg1/OlOR4LDG3dnEbc2WtFcTyTFI1cA Z2jbPusJ7ZwKkTPbpnqqi8oUCnAsaGhyswjuu9T+iZanwMkNc5aFRskNAb5phCiNhj Z2ojA+rIjlFbQ== From: Arnd Bergmann To: Greg Kroah-Hartman , Biju Das Cc: Arnd Bergmann , Tony Lindgren , Randy Dunlap , Felipe Balbi , Linus Walleij , Krzysztof Kozlowski , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] xhci: host: renesas: drop excessive Kconfig selects Date: Mon, 30 Jan 2023 14:03:41 +0100 Message-Id: <20230130130425.310410-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Arnd Bergmann The USB_XHCI_RZV2M and USB_RENESAS_USB3 select other drivers based on the enabled SoC types, which leads to build failures when the dependencies are not met: WARNING: unmet direct dependencies detected for USB_RZV2M_USB3DRD Depends on [n]: USB_SUPPORT [=y] && USB_GADGET [=n] && (ARCH_R9A09G011 [=n] || COMPILE_TEST [=y]) Selected by [m]: - USB_XHCI_RZV2M [=m] && USB_SUPPORT [=y] && USB [=y] && USB_XHCI_HCD [=m] && USB_XHCI_PLATFORM [=m] && (ARCH_R9A09G011 [=n] || COMPILE_TEST [=y]) ERROR: modpost: "rzv2m_usb3drd_reset" [drivers/usb/host/xhci-plat-hcd.ko] undefined! All the selected symbols are actually user visible, so the correct approach here is to drop the incorrect 'select' statements and have users turn on those drivers during kernel configuration as they would for any other driver. Fixes: c52c9acc415e ("xhci: host: Add Renesas RZ/V2M SoC support") Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/Kconfig | 1 - drivers/usb/host/Kconfig | 3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index 9b7a1681550f..1821004dd325 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -195,7 +195,6 @@ config USB_RENESAS_USB3 tristate 'Renesas USB3.0 Peripheral controller' depends on ARCH_RENESAS || COMPILE_TEST depends on EXTCON - select USB_RZV2M_USB3DRD if ARCH_R9A09G011 select USB_ROLE_SWITCH help Renesas USB3.0 Peripheral controller is a USB peripheral controller diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 4b5c5b1feb40..b975178b38bf 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -53,8 +53,6 @@ config USB_XHCI_PCI_RENESAS config USB_XHCI_PLATFORM tristate "Generic xHCI driver for a platform device" - select USB_XHCI_RCAR if ARCH_RENESAS - select USB_XHCI_RZV2M if ARCH_R9A09G011 help Adds an xHCI host driver for a generic platform device, which provides a memory space and an irq. @@ -100,7 +98,6 @@ config USB_XHCI_RZV2M tristate "xHCI support for Renesas RZ/V2M SoC" depends on USB_XHCI_PLATFORM depends on ARCH_R9A09G011 || COMPILE_TEST - select USB_RZV2M_USB3DRD help Say 'Y' to enable the support for the xHCI host controller found in Renesas RZ/V2M SoC.