| Message ID | 20230227112541.14849-1-k.yankevich@omp.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] usb: storage: sddr55: clean up variable type | expand |
On Mon, Feb 27, 2023 at 02:25:41PM +0300, Karina Yankevich wrote: > SVACE static analyzer complains that we're possibly > losing information by shifting an 'unsigned int pba' > variables in sddr55_{read,write}_data(). > It is a false positive, because of the card's total capacity > is no larger than 128 MB. But 'unsigned int' is more > suitable in this case. Please wrap at 72 columns. > Found by OMP on behalf of Linux Verification Center > (linuxtesting.org) with SVACE. What is "OMP"? What is "SVACE"? And why change anything if there is not a real issue? > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") That's obviously not the correct commit id for such a "fix" as this is not a real issue. thanks, greg k-h
Hello! Sorry for the really long delay! Your reply scared off Karina (it was her 1st kernel patch), so I'm trying to pick this patch up where it was left back in February... On 2/27/23 2:54 PM, Greg Kroah-Hartman wrote: [...] >> SVACE static analyzer complains that we're possibly >> losing information by shifting an 'unsigned int pba' >> variables in sddr55_{read,write}_data(). >> It is a false positive, because of the card's total capacity >> is no larger than 128 MB. But 'unsigned int' is more >> suitable in this case. > > Please wrap at 72 columns. > >> Found by OMP on behalf of Linux Verification Center >> (linuxtesting.org) with SVACE. > > What is "OMP"? Open Mobile Platform, LLC. The website is in Russian only: https://www.omp.ru > What is "SVACE"? The patch description said thst it's a static analyzer. Here's the link to the Institute for System Programming web page about it: https://www.ispras.ru/en/technologies/svace/ > And why change anything if there is not a real issue? We needlessly use 64-bit type on 64-bit arches. >> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > That's obviously not the correct commit id for such a "fix" as this is > not a real issue. That's correct. We'll remove this tag. > thanks, > > greg k-h MBR, Srrgey
On Fri, Dec 01, 2023 at 07:16:56PM +0300, Sergei Shtylyov wrote: > Hello! > > Sorry for the really long delay! Your reply scared off Karina > (it was her 1st kernel patch), so I'm trying to pick this patch up > where it was left back in February... Note, any submitter should be able to answer questions about their change, as remember, if I take it I am now responsible for it. If they do not want to respond that means they do not want to be responsible for it, which of course means we can't accept it :( thanks, greg k-h
diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c index 15dc25801cdc..0aa079405d23 100644 --- a/drivers/usb/storage/sddr55.c +++ b/drivers/usb/storage/sddr55.c @@ -196,7 +196,7 @@ static int sddr55_read_data(struct us_data *us, unsigned char *buffer; unsigned int pba; - unsigned long address; + unsigned int address; unsigned short pages; unsigned int len, offset; @@ -316,7 +316,7 @@ static int sddr55_write_data(struct us_data *us, unsigned int pba; unsigned int new_pba; - unsigned long address; + unsigned int address; unsigned short pages; int i;
SVACE static analyzer complains that we're possibly losing information by shifting an 'unsigned int pba' variables in sddr55_{read,write}_data(). It is a false positive, because of the card's total capacity is no larger than 128 MB. But 'unsigned int' is more suitable in this case. Found by OMP on behalf of Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Karina Yankevich <k.yankevich@omp.ru> --- drivers/usb/storage/sddr55.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)