diff mbox series

usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function

Message ID 20230319141053.1703937-1-trix@redhat.com (mailing list archive)
State Accepted
Commit 2271b2727aeca2e09d07f63bc61dc9757c3a5a3c
Headers show
Series usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function | expand

Commit Message

Tom Rix March 19, 2023, 2:10 p.m. UTC
clang with W=1 reports
drivers/usb/typec/tcpm/tcpci_mt6360.c:46:19: error: unused function
  'mt6360_tcpc_read16' [-Werror,-Wunused-function]
static inline int mt6360_tcpc_read16(struct regmap *regmap,
                  ^
This function is not used, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/usb/typec/tcpm/tcpci_mt6360.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Heikki Krogerus March 20, 2023, 11:59 a.m. UTC | #1
On Sun, Mar 19, 2023 at 10:10:53AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/typec/tcpm/tcpci_mt6360.c:46:19: error: unused function
>   'mt6360_tcpc_read16' [-Werror,-Wunused-function]
> static inline int mt6360_tcpc_read16(struct regmap *regmap,
>                   ^
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpci_mt6360.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index 1b7c31278ebb..6fa8fd5c8041 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -43,12 +43,6 @@ struct mt6360_tcpc_info {
>  	int irq;
>  };
>  
> -static inline int mt6360_tcpc_read16(struct regmap *regmap,
> -				     unsigned int reg, u16 *val)
> -{
> -	return regmap_raw_read(regmap, reg, val, sizeof(u16));
> -}
> -
>  static inline int mt6360_tcpc_write16(struct regmap *regmap,
>  				      unsigned int reg, u16 val)
>  {
> -- 
> 2.27.0
diff mbox series

Patch

diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
index 1b7c31278ebb..6fa8fd5c8041 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
@@ -43,12 +43,6 @@  struct mt6360_tcpc_info {
 	int irq;
 };
 
-static inline int mt6360_tcpc_read16(struct regmap *regmap,
-				     unsigned int reg, u16 *val)
-{
-	return regmap_raw_read(regmap, reg, val, sizeof(u16));
-}
-
 static inline int mt6360_tcpc_write16(struct regmap *regmap,
 				      unsigned int reg, u16 val)
 {