| Message ID | 20230413173150.71387-2-sebastian.reichel@collabora.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | generic-ohci/ehci: add RK3588 support | expand |
On Thu, 13 Apr 2023 19:31:48 +0200, Sebastian Reichel wrote: > Add compatible for RK3588 OHCI. As far as I know it's fully > compatible with generic-ohci. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../devicetree/bindings/usb/generic-ohci.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/generic-ohci.example.dtb: usb@1c14400: clocks: [[4294967295, 6], [4294967295, 2]] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/generic-ohci.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230413173150.71387-2-sebastian.reichel@collabora.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 13/04/2023 19:31, Sebastian Reichel wrote: > Add compatible for RK3588 OHCI. As far as I know it's fully > compatible with generic-ohci. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Sebastian, Can you fix PATCH subject part in all your submissions? There should be a space between PATCH and v. Just like `git format-patch` creates. If you use other tools for this, fix them so they don't create other format. You also need to rebase your patches - this is something old and cannot be applied. > --- > .../devicetree/bindings/usb/generic-ohci.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > index a9ba7257b884..4feb993af53b 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -44,6 +44,7 @@ properties: > - hpe,gxp-ohci > - ibm,476gtr-ohci > - ingenic,jz4740-ohci > + - rockchip,rk3588-ohci > - snps,hsdk-v1.0-ohci > - const: generic-ohci > - enum: > @@ -69,7 +70,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 3 > + maxItems: 4 > description: | > In case the Renesas R-Car Gen3 SoCs: > - if a host only channel: first clock should be host. > @@ -147,6 +148,19 @@ allOf: > then: > properties: > transceiver: false > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3588-ohci > + then: > + properties: > + clocks: > + minItems: 4 > + else: > + properties: > + clocks: Please test the patches before sending. If you tested, you would see warnings here. You need minItems: 1. > + maxItems: 3 > > additionalProperties: false > Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml index a9ba7257b884..4feb993af53b 100644 --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml @@ -44,6 +44,7 @@ properties: - hpe,gxp-ohci - ibm,476gtr-ohci - ingenic,jz4740-ohci + - rockchip,rk3588-ohci - snps,hsdk-v1.0-ohci - const: generic-ohci - enum: @@ -69,7 +70,7 @@ properties: clocks: minItems: 1 - maxItems: 3 + maxItems: 4 description: | In case the Renesas R-Car Gen3 SoCs: - if a host only channel: first clock should be host. @@ -147,6 +148,19 @@ allOf: then: properties: transceiver: false + - if: + properties: + compatible: + contains: + const: rockchip,rk3588-ohci + then: + properties: + clocks: + minItems: 4 + else: + properties: + clocks: + maxItems: 3 additionalProperties: false